[Example] add flashattention in example and modify ci test - #564
Open
RuizeYu05 wants to merge 6 commits into
Open
[Example] add flashattention in example and modify ci test#564RuizeYu05 wants to merge 6 commits into
RuizeYu05 wants to merge 6 commits into
Conversation
Member
|
Thanks for your PR! I think you also need to update the |
Author
|
Yeah I'm currently fixing it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a FlashAttention example kernel implemented in Allo and wires it into CI so the example is exercised during PR runs.
Changes:
- Added a FlashAttention Allo schedule/kernel implementation (
get_scheduled_flash_attention). - Added a Python testbench that builds/runs the kernel and compares against a NumPy golden reference.
- Updated GitHub Actions workflow to execute the FlashAttention testbench.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
examples/flashattention/test_flash.py |
Testbench that computes a golden attention output and validates the Allo-generated kernel (plus optional Vitis HLS synthesis). |
examples/flashattention/flash_Atten.py |
Allo implementation/schedule for a tiled FlashAttention-style attention computation. |
.github/workflows/config.yml |
Adds a CI step to run the FlashAttention testbench. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
chhzh123
reviewed
Mar 8, 2026
chhzh123
left a comment
Member
There was a problem hiding this comment.
Can you fix Copilot's suggestions (if they are valid)? Also, it'd be good to attach your performance results in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I add the example of implementing flash attention using allo and modify the CI test to support the testing of my flash attention kernel.
Problems
Implementing flash attention using allo
Proposed Solutions
Add an example to the application of allo
Examples
Checklist
Please make sure to review and check all of these items: