Feat/google docs plan step v0 [INTEG-3341]#10360
Open
david-shibley-contentful wants to merge 14 commits intomasterfrom
Open
Feat/google docs plan step v0 [INTEG-3341]#10360david-shibley-contentful wants to merge 14 commits intomasterfrom
david-shibley-contentful wants to merge 14 commits intomasterfrom
Conversation
* wip * simplify agent * organize oauth functions * reorganizing function handlers * reorganizing function handlers (prev `createEntriesfromDocument`) calling each agent in a separate function, + removing plan agent for now * fix: function manifest * minor edit to manifest * replacing single function with 2: one for analyzing ct + one for document processing * fix: add oauth token to analyze content type function * fix: adding entries to document processor o/p * feat: new app action to create entries, preview modal * cleanup + rename preview function * cleanup * chore: delete test docs * cleanup * rename handler for consistency
* feat: got google doc picker working * feat: explicitly add api key for google docs oauth connection
david-shibley-contentful
changed the title
Comment on lines
+62
to
+81
| const analyzeContentTypesResponse = await analyzeContentTypesAction( | ||
| sdk, | ||
| contentTypeIds, | ||
| oauthToken | ||
| ); | ||
| console.log('analyzeContentTypesResponse', analyzeContentTypesResponse); | ||
| // If entries provided, use them directly. Otherwise fetch document JSON as fallback | ||
| let documentJson: unknown | undefined; | ||
| if (!entries || entries.length === 0) { | ||
| documentJson = await fetchGoogleDocAsJson(documentId, oauthToken); | ||
| } | ||
|
|
||
| const processDocumentResponse = await createPreviewAction( | ||
| const response = await createEntriesFromDocumentAction( | ||
| sdk, | ||
| contentTypeIds, | ||
| documentId, | ||
| oauthToken | ||
| ); | ||
| console.log('processDocumentResponse', processDocumentResponse); | ||
| entries, | ||
| documentJson | ||
| ) as any; | ||
| const result: FinalEntriesResult = response.sys.result; |
Contributor
There was a problem hiding this comment.
should we revert to using two functions instead of one?
Contributor
Author
There was a problem hiding this comment.
i'm not sure I understand, aren't we using two functions?
Contributor
There was a problem hiding this comment.
I looked into it and the createPreview function only calls the document parser agent and not the content type parser agent (this agent was called by the analyzeContentTypes function that was deleted in the manifest) Was that intentional? If so we would need to delete the content type parser agent.
|
|
||
| const submit = useCallback( | ||
| async (contentTypeIds: string[]) => { | ||
| async (contentTypeIds: string[], entries?: any[]) => { |
Contributor
There was a problem hiding this comment.
Why do we have a diff here? Isn't this part for the content type analysis, but now we are fetching the docs and calling create entries? I think this is not what this hook is intended for
Contributor
Author
There was a problem hiding this comment.
no?
| }, [isSubmitting, modalStates.isLoadingModalOpen, closeModal, clearPlan]); | ||
|
|
||
| // Handle plan generation completion | ||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
where did this come from
Contributor
Author
There was a problem hiding this comment.
we need this to get the modals to switch when the preview is generated
david-shibley-contentful
force-pushed
the
feat/google-docs-plan-step-v0
branch
from
bf31297 to
6c505b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The preview step was the final missing piece of the flow
Things introduced in this PR:
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment