Skip to content

cpuclass: restore uncore limits when no class needs them. - #873

Open
kad wants to merge 1 commit into
containers:mainfrom
kad:fix/uncore-restore
Open

kad wants to merge 1 commit into
containers:mainfrom
kad:fix/uncore-restore

Conversation

@kad

@kad kad commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

The uncore writer skipped dies with both effective limits at 0, so limits set by a not anymore active class stayed in sysfs. A pod using a class with uncoreMinFreq left the die at that minimum after it finished. A min dropping to 0 while a max remained was skipped for the same reason.

Track what was written to each die and write the hardware default back when no class requests the limit any more. The sysfs writer clamps to the hardware range, so 0 and MaxInt32 end up as the hardware min and max.

@kad
kad requested a review from askervin October 24, 2026 09:59
The uncore writer skipped dies with both effective limits at 0, so
limits set by a not anymore active class stayed in sysfs. A pod
using a class with uncoreMinFreq left the die at that minimum after
it finished. A min dropping to 0 while a max remained was skipped
for the same reason.

Track what was written to each die and write the hardware default back
when no class requests the limit any more. The sysfs writer clamps to
the hardware range, so 0 and MaxInt32 end up as the hardware min and
max.

Signed-off-by: Alexander Kanevskiy <alexander.kanevskiy@intel.com>
@kad
kad force-pushed the fix/uncore-restore branch from 4aa1c92 to 6fa8e84 Compare October 24, 2026 10:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants