Open
Conversation
preethamr
previously requested changes
Aug 24, 2024
Collaborator
preethamr
left a comment
There was a problem hiding this comment.
Still fails e2e on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to dependencies and refactors to improve the codebase's compatibility with the latest versions of the
@arbitrum/sdkpackage. The changes involve updating package dependencies, modifying imports and exports, and adjusting test cases to reflect the new SDK structure.Dependency Updates:
@arbitrum/sdkto version4.0.1and@eth-optimism/sdkto version3.3.2inpackages/agents/lighthouse/package.jsonandpackages/deployments/contracts/package.json. [1] [2]Code Refactoring:
L2TransactionReceiptwithChildTransactionReceiptandL1ToL2MessageGasEstimatorwithParentToChildMessageGasEstimatoracross multiple files includingpackages/agents/lighthouse/src/mockable.tsandpackages/agents/lighthouse/src/tasks/processFromRoot/helpers/arbitrum.ts. [1] [2] [3] [4] [5] [6] [7] [8]Test Adjustments:
L2ToL1MessageReaderwithChildToParentMessageReaderinpackages/agents/lighthouse/test/tasks/processFromRoot/helpers/arbitrum.spec.tsandpackages/agents/lighthouse/test/tasks/propagate/helpers/arbitrum.spec.ts. [1] [2] [3] [4]New Features:
packages/agents/lighthouse/example.http.These changes ensure that the codebase remains up-to-date with the latest SDK versions and maintain compatibility across different modules.## Description
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)