Add sort by gist description or file extension alphabetically option.#155
Open
joshmfrankel wants to merge 1 commit intocondemil:masterfrom
Open
Add sort by gist description or file extension alphabetically option.#155joshmfrankel wants to merge 1 commit intocondemil:masterfrom
joshmfrankel wants to merge 1 commit intocondemil:masterfrom
Conversation
…rts alphabetically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two methods into helpers.py: set_sort_data and sort_gists_data. The first helps prepare the code for proper sorting. It is called inside gists_filter() method for loop. Second method performs the actual sorting logic. It is called at the end of gists_filter() method.
Also have added documentation to README.md and Settings Usage in Gist.sublime-settings.
I am new to python programming so optimizations and/or fixes are greatly appreciated.