Skip to content

fix: wipe migrated config files too when clearing dead registrations #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compscidr merged 1 commit into from
Aug 11, 2026
Merged

fix: wipe migrated config files too when clearing dead registrations #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion preflight-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,33 @@

log() { echo "[preflight] $*"; }

# The runner's IsConfigured()/HasCredentials() checks treat .runner_migrated /
# .credentials_migrated as equivalent to the primary files, so a wipe must
# remove all five or config.sh refuses to re-register while run.sh can't load
# settings ("Value cannot be null. (Parameter 'configuredSettings')") — a
# crash loop that never self-heals. The files are removed from /actions-runner
# too: the writable layer survives restarts, and the upstream entrypoint's
# persist-back step otherwise re-seeds the persist dir from it.
wipe_registration() {
local dir="$1" f
for f in .runner .credentials .credentials_rsaparams .runner_migrated .credentials_migrated; do
rm -f "$dir/$f" "/actions-runner/$f"
done
}

preflight() {
local dir="${CONFIGURED_ACTIONS_RUNNER_FILES_DIR:-}"
[ -n "$dir" ] || return 0

# Heal the wedged state left behind by a partial wipe (an older preflight or
# manual cleanup that removed .runner but not .runner_migrated): without
# .runner there is nothing to validate, and the orphaned migrated files
# alone block registration.
if [ ! -f "$dir/.runner" ] && [ -f "$dir/.runner_migrated" ]; then
log "orphaned .runner_migrated without .runner; removing it so registration can proceed"
wipe_registration "$dir"
fi

[ -f "$dir/.runner" ] || return 0
if [ -z "${ACCESS_TOKEN:-}" ]; then
log "ACCESS_TOKEN not set; cannot validate persisted registration, leaving as-is"
Expand Down Expand Up @@ -86,7 +110,7 @@ preflight() {
404)
log "persisted runner agentId=${agent_id} no longer exists on ${github_host};" \
"wiping persisted registration to force fresh ACCESS_TOKEN registration"
rm -f "$dir/.runner" "$dir/.credentials" "$dir/.credentials_rsaparams"
wipe_registration "$dir"
;;
*)
log "could not validate persisted runner (HTTP ${status:-none}); leaving as-is"
Expand Down