unicode -> ascii

[sowbug]

Please merge this PR. I think the issue is that newer versions of Python interpret plain strings as Unicode rather than ASCII, which happened to work in this case as functionally equivalent to octet sequences. We resolve the issue by being explicit that we want binary sequences, not strings.

While I'm here, please resolve #2. I'm using this library as part of a PR on offer to a fork of Stable Diffusion (https://github.com/basujindal/stable-diffusion), and it'll look more canonical if the package is on pypi.

Thanks!

[artfwo]

Thanks! I recall we don't have a PyPI account for Commons Machinery, unfortunately. Is there a problem with installing this from GitHub?

[sowbug]

Thanks for merging. As for whether there's a problem installing from GitHub, I can't answer for others who might consider using the library, but in my case I took the lack of ordinary pip installability as a negative social signal on the library's viability. Basically, if the library's maintainers haven't made the library available via pip, then what else haven't they done? (Sorry if that sounds harsh; I'm just channeling a typical thought process when an app developer is comparing libraries.) All that said, I ended up using it, because it was the only XMP library written in pure Python. Relevance is this PR basujindal/stable-diffusion#123. I don't know whether the PR will be accepted, as a lot of bikeshedding about metadata has begun.

…

On Thu, Sep 22, 2022 at 12:32 PM Artem Popov ***@***.***> wrote: Thanks! I recall we don't have a PyPI account for Commons Machinery, unfortunately. Is there a problem with installing this from GitHub? — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHMVFCFURTWJVC4VNTHD3V7SX6NANCNFSM6AAAAAAQGB2DSY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[artfwo]

Right, unfortunately that's true. We haven't done much to make this library user-friendly at the time of writing it - it was an experimental piece of code to explore the possibilities of using raw XMP in another project.

Since Commons Machinery no longer exists as a (physical) organization, finding a volunteer for release management and maintaining the PyPI package might not be easy, but personally I have no problem with somebody forking and maintaining the library if it is actively used elsewhere.

[sowbug]

Makes sense. In the event my PR is merged, maybe I'll just incorporate your code into the app, and then the whole pypi issue is moot for purposes of this project. Thanks again.

…

On Thu, Sep 22, 2022 at 1:17 PM Artem Popov ***@***.***> wrote: Right, unfortunately that's true. We haven't done much to make this library user-friendly at the time of writing it - it was an experimental piece of code to explore the possibilities of using raw XMP in another project. Since Commons Machinery no longer exists as a (physical) organization, finding a volunteer for release management and maintaining the PyPI package might not be easy, but personally I have no problem with somebody forking and maintaining the library if it is actively used elsewhere. — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHMVCZLOQFXXXRNGAWDMDV7S5FRANCNFSM6AAAAAAQGB2DSY> . You are receiving this because you authored the thread.Message ID: ***@***.***>