Repository navigation
Conversation
syn 3 replaced TraitBound::modifier with modifiers and maybe. The macro crate parses the same syn types, so it moves to syn 3 as well.
TedDriggs
requested changes
Oct 29, 2026
TedDriggs
left a comment
Collaborator
There was a problem hiding this comment.
After bumping the MSRV, please rerun the compiletests with TRYBUILD=overwrite and commit the updated compiletest output as part of this PR.
Once those things are changed, CI should pass and this will be ready to merge.
| description = "Internal helper library for the derive_builder crate." | ||
| repository = "https://github.com/colin-kiegel/rust-derive-builder" | ||
| documentation = "https://docs.rs/derive_builder_core" | ||
| rust-version = "1.56.0" |
Collaborator
There was a problem hiding this comment.
We'll need to drop 1.56 support for this, based on the CI failures.
Please update the MSRV in README.md and in the rust-version field of all the Cargo.toml files.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syn 3 replaced TraitBound::modifier with modifiers and maybe. The macro crate parses the same syn types, so it moves to syn 3 as well.