Skip to content

Update derive_builder to syn 3 and darling 0.24 - #357

Open
tsimonq2 wants to merge 1 commit into
colin-kiegel:masterfrom
tsimonq2:syn-3
Open

tsimonq2 wants to merge 1 commit into
colin-kiegel:masterfrom
tsimonq2:syn-3

Conversation

@tsimonq2

@tsimonq2 tsimonq2 commented Oct 3, 2026

Copy link
Copy Markdown

syn 3 replaced TraitBound::modifier with modifiers and maybe. The macro crate parses the same syn types, so it moves to syn 3 as well.

syn 3 replaced TraitBound::modifier with modifiers and maybe. The macro
crate parses the same syn types, so it moves to syn 3 as well.

@TedDriggs TedDriggs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After bumping the MSRV, please rerun the compiletests with TRYBUILD=overwrite and commit the updated compiletest output as part of this PR.

Once those things are changed, CI should pass and this will be ready to merge.

description = "Internal helper library for the derive_builder crate."
repository = "https://github.com/colin-kiegel/rust-derive-builder"
documentation = "https://docs.rs/derive_builder_core"
rust-version = "1.56.0"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to drop 1.56 support for this, based on the CI failures.

Please update the MSRV in README.md and in the rust-version field of all the Cargo.toml files.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants