fix(ci): report skipped Node jobs so native-only PRs can merge - #879
Closed
adrienzheng-cb wants to merge 1 commit into
Closed
fix(ci): report skipped Node jobs so native-only PRs can merge#879adrienzheng-cb wants to merge 1 commit into
adrienzheng-cb wants to merge 1 commit into
Conversation
Branch protection requires Node / Build and related checks. Skipping the entire Node workflow never reports those names, so native-only PRs stay blocked even when Android and iOS pass. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Always call the Node reusable workflow, and skip its jobs when the classifier says Node is unaffected. Skipping the whole workflow never reports required
Node / Build(and related) checks, so GitHub leaves native-only PRs blocked even when Android and iOS pass. Skipped jobs still count as passing required checks.Unblocks native-only PRs such as #878 after this lands and they rebase.
Root cause (required for bugfixes)
#867 started skipping the Node workflow for native-only changes. Branch protection still requires the
Node / *check names. A skipped workflow does not create those checks, so they stay pending.UI changes
N/A — CI only.
Testing
How has it been tested?
This PR changes
ci.yml, which forces every toolchain, so Node will run for real here. After merge, a native-only PR should show skippedNode / *jobs and be mergeable.Testing instructions
Node / *checks report skipped and no longer block merge.Illustrations/Icons Checklist
N/A
Change management
type=routine
risk=low
impact=sev5
automerge=false
Made with Cursor