Repository navigation
feat: Build in new component style affordances - #839
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
Contributor
Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
… Tabs, SegmentedTabs and add more style customization options to some other components
Adds a `variant` prop (primary/positive/negative) to Switch on mobile and web that sets the track's checked background using the same semantic colors as other control components, while the `background` prop and custom styles still take priority. Also adds a 0.5px `bgLine` border around the switch head/handle (already present on web; now added to mobile) without changing its size, plus story examples for the new variants. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
cb-ekuersch
force-pushed
the
erich/customer-component-config
branch
from
August 11, 2026 19:29
a6461b3 to
80fcec9
Compare
hcopp
reviewed
Aug 11, 2026
Address PR feedback by setting alignSelf/width defaults directly in the destructuring instead of computing separate resolved variables, on both mobile and web. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
adrienzheng-cb
previously approved these changes
Aug 11, 2026
adrienzheng-cb
approved these changes
Aug 11, 2026
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
borderRadiusandshowItemSeparatorsprops, register with the Component Config system, and add staticstyles/classNamessupport (web) for config-driven customization.borderRadiusprop,showHeaderBorder, and register with the Component Config system.BasePropsfor config-driven spacing, keep the headerPressabletransparent while inactive, addtertiaryTitle/caretSize/backgroundprops, and movestylefromBasePropstoProps.stylefromBasePropstoPropsfor consistency with the rest of the library.variantprop for convenience - setting background is already possibleequalWidthprop so tabs stretch to fill their container equally (web also auto-defaultswidthto100%when set).Root cause (required for bugfixes)
UI changes
New demo for custom theme/config
retail.config.demo.mov
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false