Repository navigation
fix: do not wrap checkbox labels with ReactNode in text - #838
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
hcopp
marked this pull request as ready for review
August 25, 2026 15:07
Contributor
| onChange={(event) => setIsCondensed(event.currentTarget.checked)} | ||
| > | ||
| Spacing variant: {spacingVariant} | ||
| {`Spacing variant: ${spacingVariant}`} |
Contributor
There was a problem hiding this comment.
nit: why do we need the template literal here
Contributor
Author
There was a problem hiding this comment.
It was labeled as a react node without this change
Contributor
Author
There was a problem hiding this comment.
@adrienzheng-cb does that make you concerned to make this change as a whole?
adrienzheng-cb
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR fixes
<Checkbox ...><Text font="label2">My checkbox label</Text></Checkbox>and other instances where teams pass in custom ReactNodes into checkbox. Previously it would appear to have incorrect vertical text alignment.Root cause (required for bugfixes)
Control picked 'children' from TextProps which supports ReactNode but it didn't handle the case of users passing in a custom reactnode differently than string. As a result, we received misaligned text in these instances.
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false