Skip to content

fix: reuse initial path on mobile charts #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hcopp merged 2 commits into from
Aug 10, 2026
Merged

fix: reuse initial path on mobile charts #837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db66eb
fix: reuse initial path on mobile charts
hcopp Aug 10, 2026
10e62b6
Bump version
hcopp Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/common/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ All notable changes to this project will be documented in this file.

<!-- template-start -->

## 9.12.3 ((8/10/2026, 09:17 AM PST))

This is an artificial version bump with no new change.

## 9.12.2 ((8/10/2026, 07:45 AM PST))

This is an artificial version bump with no new change.
Expand Down
2 changes: 1 addition & 1 deletion packages/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coinbase/cds-common",
"version": "9.12.2",
"version": "9.12.3",
"description": "Coinbase Design System - Common",
"repository": {
"type": "git",
Expand Down
4 changes: 4 additions & 0 deletions packages/mcp-server/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ All notable changes to this project will be documented in this file.

<!-- template-start -->

## 9.12.3 ((8/10/2026, 09:17 AM PST))

This is an artificial version bump with no new change.

## 9.12.2 ((8/10/2026, 07:45 AM PST))

This is an artificial version bump with no new change.
Expand Down
2 changes: 1 addition & 1 deletion packages/mcp-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coinbase/cds-mcp-server",
"version": "9.12.2",
"version": "9.12.3",
"description": "Coinbase Design System - MCP Server",
"repository": {
"type": "git",
Expand Down
6 changes: 6 additions & 0 deletions packages/mobile/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ All notable changes to this project will be documented in this file.

<!-- template-start -->

## 9.12.3 (8/10/2026 PST)

#### 🐞 Fixes

- Fix: reuse initial path on mobile charts. [[#837](https://github.com/coinbase/cds/pull/837)]

## 9.12.2 (8/10/2026 PST)

#### 🐞 Fixes
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coinbase/cds-mobile",
"version": "9.12.2",
"version": "9.12.3",
"description": "Coinbase Design System - Mobile",
"repository": {
"type": "git",
Expand Down
8 changes: 5 additions & 3 deletions packages/mobile/src/visualizations/chart/utils/transition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useMemo, useRef } from 'react';
import { useEffect, useMemo, useRef, useState } from 'react';
import {
type ExtrapolationType,
type SharedValue,
Expand Down Expand Up @@ -265,8 +265,10 @@ export const usePathTransition = ({
const interpolatorRef = useRef<((t: number) => string) | null>(null);
const progress = useSharedValue(0);

const initialSkiaPath =
Skia.Path.MakeFromSVGString(initialPath ?? currentPath) ?? Skia.Path.Make();
// Re-renders must not re-parse SVG; lazy useState seeds useSharedValue on mount only.
const [initialSkiaPath] = useState(
() => Skia.Path.MakeFromSVGString(initialPath ?? currentPath) ?? Skia.Path.Make(),
);

@adrienzheng-cb adrienzheng-cb Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we declare it as a ref?

@hcopp hcopp Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrienzheng-cb we could, we'd need to do something like

const initialSkiaPathRef = useRef(null); // not sure what type is off the top of my header

if (initialSkiaPathRef.current === null) { 
  initialSkiaPathRef.current = Skia.Path.MakeFromSVGString(initialPath ?? currentPath) ?? Skia.Path.Make()
}

Since useRef doesn't support lazy loading. Would you prefer this?

@adrienzheng-cb adrienzheng-cb Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o I see. let's keep the useState then. I was asking because I prefer refs to states, whose update methods are unused.

@hcopp hcopp Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thinking about this!

const normalizedStartShared = useSharedValue(initialSkiaPath);
const normalizedEndShared = useSharedValue(initialSkiaPath);
const fallbackPathShared = useSharedValue(initialSkiaPath);
Expand Down
4 changes: 4 additions & 0 deletions packages/web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ All notable changes to this project will be documented in this file.

<!-- template-start -->

## 9.12.3 ((8/10/2026, 09:17 AM PST))

This is an artificial version bump with no new change.

## 9.12.2 ((8/10/2026, 07:45 AM PST))

This is an artificial version bump with no new change.
Expand Down
2 changes: 1 addition & 1 deletion packages/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@coinbase/cds-web",
"version": "9.12.2",
"version": "9.12.3",
"description": "Coinbase Design System - Web",
"repository": {
"type": "git",
Expand Down
Loading