Repository navigation
feat(cu): sync observation diffs and named batches across consumers - #12
Merged
Merged
Conversation
Mirror canonical 33ab021b1e3f and update .upstream-sha. Include the canonical Windows target/fixture origin fixes missing from this consumer. Refresh the existing extension guide and reviewed wiki source seal. Validation: npm test: 1067 total, 1031 passed, 0 failed, 36 skipped; check:web: 13 passed, 0 failed, 9 skipped. Catalog check passes (47 skills); wiki: 3 fresh, 0 stale. Full runtime equality with canonical and the Engine vendored consumer passes, preserving deliberate Core variants. Diff check passes. No installed build, real-model, release or deploy claim. Refs SHA-6645; packaged/model acceptance remains open under SHA-6352/C16.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Changes recommended
Named lookup can act from incomplete trees, and absence waits incorrectly fail when the application disappears.
2 open findings
What changed in this PR
Syncs the Computer Use mirror to canonical commit 33ab021, adding observation diffs, named action batches, platform fixes, tests, and refreshed documentation.
Changes:
- Adds state diffs and safer, richer action batches.
- Improves macOS key/filter handling and Windows geometry fixtures.
- Updates operating guidance and WhaleWiki seals.
| File | Description |
|---|---|
whalewiki/pages/extensions.md |
Documents new workflows. |
whalewiki/manifest.json |
Refreshes source seals. |
plugins/computer-use/.upstream-sha |
Pins canonical commit. |
plugins/computer-use/CHANGELOG.md |
Records changes. |
plugins/computer-use/docs/CUA_PARITY.md |
Updates parity review. |
plugins/computer-use/mcp/server.mjs |
Implements diffs and batches. |
plugins/computer-use/src/tools.mjs |
Extends tool schemas. |
plugins/computer-use/src/trajectory.mjs |
Handles aliased batch redaction. |
plugins/computer-use/src/backends/darwin.mjs |
Adds filtering and key aliases. |
plugins/computer-use/src/backends/win32.mjs |
Safens UIA geometry. |
plugins/computer-use/skills/computer-use/SKILL.md |
Updates operating guidance. |
plugins/computer-use/skills/computer-use/references/refusal-codes.md |
Documents batch failures. |
plugins/computer-use/skills/computer-use/references/quick-reference.md |
Documents new arguments. |
plugins/computer-use/tests/server-targets.test.mjs |
Tests diffs and batches. |
plugins/computer-use/tests/wait-for.test.mjs |
Tests wait revalidation. |
plugins/computer-use/tests/grants.test.mjs |
Tests grant isolation. |
plugins/computer-use/tests/trajectory-redact.test.mjs |
Tests alias redaction. |
plugins/computer-use/tests/darwin.test.mjs |
Tests macOS behavior. |
plugins/computer-use/tests/win32-targeting.test.mjs |
Tests Windows geometry. |
plugins/computer-use/tests/fixtures/fake-backend.mjs |
Supports observation sequences. |
plugins/computer-use/tests/fixtures/windows-desktop.ps1 |
Makes receipt writes atomic. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Pin canonical 6f4050ecd1eb and refresh reviewed source seals. Reject named lookup and absence inferred from truncated walks, preserve missing-app absent wait success, and keep permission/fatal errors refused. Document non-atomic runtime checks and preserve existing completed-effect receipts. Validation: npm test 1071 total, 1035 passed, 0 failed, 36 skipped; check:web 13 passed, 0 failed, 9 skipped. Catalog, 3 fresh wiki pages, full three-tree runtime byte comparison and diff check pass. Refs SHA-6645.
Pin canonical 59725a28b224. Validate resolved computer aliases, reuse pure argument checks before batch input, and keep failed wait rechecks ephemeral. Refresh the owning wiki source seals. Validation: npm test 1072 total, 1036 passed, 0 failed, 36 skipped; check:web 13 passed, 0 failed, 9 skipped. Full three-tree runtime comparison, 3 fresh wiki pages and diff checks pass. Catalog previously passed; this follow-up changes only the same CU runtime/tests/docs and source seal. No installed/model/release/deploy qualification claim. Refs SHA-6645.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync Computer Use to canonical 59725a2: observation diffs, fresh named targets in bounded action batches, accurate completed-effect receipts, deeper macOS filtered reads and common key aliases. Preserve the consumer's existing runtime and permission model. Include canonical Windows target/fixture fixes missing from this mirror and update the extension guide/source seal.
Validation: 1,036 passed, 0 failed, 36 skipped in
npm test; 13 passed, 0 failed, 9 skipped incheck:web. Catalog and wiki checks pass (47 skills; 3 fresh pages). Full runtime equality with canonical and the Engine bundle passes, preserving deliberate Core package/README/manifest variants. Native source fixture evidence belongs to the canonical change; this is not an installed/model task or a release.Refs SHA-6645; SHA-6352/C16 remains open.
Review fixes are mirrored: truncated searches cannot prove uniqueness/absence, app closure satisfies absent waits without a target state, and denial/fatal errors remain refused. Full final-source mirror, wiki and catalog checks pass. All 1,072 tests are accounted for above; hosted checks must pass on the current head.
Final review follow-up validates merged computer aliases after resolution, shares existing pure argument checks for preflight, and preserves previous usable targeting state on unsuccessful wait rechecks. All reviewed source copies match the pinned canonical commit
59725a28b224; fresh CI must qualify this head.