Repository navigation
Fix Windows PTY initialization on the GPUI host fork - #1
Merged
Merged
Conversation
alacritty_terminal 0.26's tty::Options has a field that exists only on Windows, so the crate failed to compile there with E0063. Each launch argument is one argv entry, so they are escaped by the C runtime rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit a6119f1)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Windows compilation and PTY runtime validation remain pending for this platform-specific fix.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes the terminal launcher’s missing Windows-only PTY option.
Changes:
- Sets
escape_args: trueon Windows to enable Alacritty’s argument escaping, leaving Unix initialization unchanged.
| File | Description |
|---|---|
src/terminal/pty.rs |
Adds the Windows-gated escape_args initializer. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the terminal Options initializer omits alacritty_terminal 0.26's Windows-only escape_args field and fails to compile with E0063. Reuse upstream a6119f1's exact two-line fix: each Launch argument remains an argv entry through Alacritty's existing C-runtime escaping.
The upstream author and cherry-pick provenance are preserved; GPUI snapshot and host-theme patches remain. Validation: 3 existing Unix PTY tests passed, 0 failed, including actual process output and cwd refusal; format and diff checks passed. Exact new-pin Windows app compilation/native checks are pending and remain distinct from Windows PTY runtime acceptance.