-
Notifications
You must be signed in to change notification settings - Fork 15
feat(utils): add WriteAheadLog classes #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit a3641d3
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit f5a0e21 with previous commit 270b474. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👍 12 audits improved, 👎 1 audit regressed, 14 audits changed without impacting score🗃️ Groups
32 other groups are unchanged. 🛡️ Audits
652 other audits are unchanged. |
# Conflicts: # packages/utils/src/lib/sink-source.types.ts
# Conflicts: # testing/test-utils/src/lib/utils/perf-hooks.mock.ts
Code PushUp🥳 Code PushUp report has improved – compared current commit f5a0e21 with previous commit 270b474. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 45 | 🟡 51 | |
| Code coverage | 🟢 95 | 🟢 95 |
4 other categories are unchanged.
👍 2 groups improved, 👍 9 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDocs coverage | Documentation coverage | 🔴 45 | 🟡 51 | |
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Classes coverage | 🟨 3 undocumented classes | 🟨 3 undocumented classes | |
| JSDocs coverage | Properties coverage | 🟥 27 undocumented properties | 🟥 37 undocumented properties | |
| JSDocs coverage | Types coverage | 🟥 66 undocumented types | 🟨 56 undocumented types | |
| JSDocs coverage | Functions coverage | 🟥 239 undocumented functions | 🟥 242 undocumented functions | |
| JSDocs coverage | Variables coverage | 🟥 49 undocumented variables | 🟥 57 undocumented variables | |
| JSDocs coverage | Methods coverage | 🟨 13 undocumented methods | 🟨 15 undocumented methods | |
| Code coverage | Function coverage | 🟩 96.2 % | 🟩 96.6 % | |
| Code coverage | Branch coverage | 🟩 91.8 % | 🟩 92.2 % | |
| Code coverage | Line coverage | 🟩 97.8 % | 🟩 98 % |
435 other audits are unchanged.
13 other projects are unchanged.
Related: #1197
This PR includes:
wal.ts- general WriteAheadLog and sharded WAL inc format and filenameswal-trace-json.tstraceEvent specific login for a WALNote
This PR addresses a comment related to logging.
It could also be used as file output for the logger
Warning
All filesystem operations in WAL—and indirectly in the profiler—are synchronous by design.
The
eslintrules are disables over file name patternWhy synchronous
fsis used for WAL code?process.on('exit')cannot safely run async I/O