Open
Conversation
# Conflicts: # src/ConductorSharp.Engine/ConductorSharp.Engine.csproj # src/ConductorSharp.Engine/TypePollSpreadingExecutionManager.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes MediatR package and all corresponding references to MediatR in code. This required us to implement mechanism similar to MediatR. I used this opportunity to implement a mechanism that is similar but more closely related to Conductor itself.
List of major changes:
WorkerInvokerServicemechanism which implements basic MediatR-like functionality required for ConductorSharp (this includes Behaviors which were renamed to WorkerMiddleware and Handlers which are referred in code as Workers)IRequest<TOutput>with custom interface (ITaskInput<TOutput>)WorkerInvokerServiceNote that this is breaking change (i.e. will become part of v4, hence v3 branch is created where v3 development will continue).