Conversation
https://kitchen.ci/ Kitchen CI helps testing infrastructure code. Since ipmininet supports various distributions kitchen.ci can help testing the provisioning scripts.
|
If you wanna try, you could install the ruby gem If the installation works, you do a |
|
Currently there are at least two issues with that PR:
I just created the PR to show you the kitchen workflow, so you can decide if it makes sense to add. |
jadinm
left a comment
There was a problem hiding this comment.
This could make sense. I don't know how to solve the build_vm.sh stucked however.
Maybe this is due to the updates of the grub which require user interactions.
|
|
||
| provisioner: | ||
| name: shell | ||
| command: /opt/ipmininet/util/build_vm.sh |
There was a problem hiding this comment.
| command: /opt/ipmininet/util/build_vm.sh | |
| command: /opt/ipmininet/util/build_vm.sh && sudo pytest -v /opt/ipmininet |
There was a problem hiding this comment.
Kitchen supplies a config section (verifiers) for running tests https://kitchen.ci/docs/getting-started/writing-test/. Separating the provisioning and the tests. I suggest adding the tests there.
|
|
||
| provisioner: | ||
| name: shell | ||
| command: sudo python /opt/ipmininet/util/install.py -a |
There was a problem hiding this comment.
| command: sudo python /opt/ipmininet/util/install.py -a | |
| command: if which apt; then sudo apt install -y python; elif which yum; then sudo yum install -y python; fi; sudo python /opt/ipmininet/util/install.py -iam && sudo pytest -v /opt/ipmininet |
There was a problem hiding this comment.
This solves the problems for all platforms
There was a problem hiding this comment.
👍 for if which apt; then sudo apt install -y python; elif which yum; then sudo yum install -y python; fi; sudo python /opt/ipmininet/util/install.py -iam
For sudo pytest -v /opt/ipmininet see #31 (comment)
| @@ -1,3 +1,5 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
It is not needed, I think
I would remove it
If this is due to that, adding |
https://kitchen.ci/
Kitchen CI helps testing infrastructure code. Since ipmininet supports
various distributions kitchen.ci can help testing the provisioning
scripts.