fix -Wunused-parameter warnings - #895
Open
20dka wants to merge 1 commit into
Open
Conversation
Contributor
|
This reminds me that the asm implementation doesn't seem to be LTO safe, just like I discovered it with a bug in Community-PIO-CH32V/framework-wch-noneos-sdk#14. Surpressing the warning about the unused parameter is the wrong way, it needs to be referenced in the assembly to make sure the first parameter is absolutely in the expected a0 register. |
Owner
|
We talked about this on-call. I think @20dka is going to be tweaking this. |
Owner
|
@maxgerhardt do you mind looking into this so we can close this out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for
[-Wunused-parameter]