Assorted Sound Fixes

[fira]

List of changes

• Introduce atom tracking in sound templates. This lets us resolve the location at latest possible. This vastly improves fidelity of sounds that are centered on a player, as they would previously be heard further away when moving due to the 0.2s delay in SSsound firing. FWIW 80% of game wrongly uses get_turf/loc when calling playsound, so it won't affect most things.
• Streamline echo handling in hot sound procs. It was creating an unused pre-allocated list, and then copying element-by-element every time even though it's only used in space-to-space combat.
• Fix echo handling - it would previously not let you set 0 values because they're falsey
• As a side effect, a space-to-space weapon heard from an interior won't use reverb anymore unless explicitely requested (has that even ever happened?!)
• Fix static sound offsets. These are only used on PVE i believe, but they were wrong because (x,y,z) in game is (x,z,y) in sound coordinates, it uses a different frame of reference.
• Small code optimizations such as using for(var/key, value) or inlining the interior check in soundOutput
• Comments
• Sound queueing is disabled during early Subsystem Initialization. This avoids it coming to life with 500 sounds to play and causing a small hiccup. I don't know where the sounds come from. Presumably they're rustling from manipulating items and such, but they should all be in nullspace.

Changelog

🆑
code: Some sounds will now be emitted from the emitting object rather than the ground position. This especially makes a difference for sounds originating from your character, which won't be shifted when you move due to delay.
/:cl:

[cm13-github]

Test merge deployment history:

Test Merge Deployed @ 07/26/2026 06:02:58 +00:00:

Server Instance

CM13 Live

Revision

Origin: 1cb954c
Pull Request: a1cfb29
Server: cd4630d

Test Merge Updated @ 07/26/2026 06:40:59 +00:00:

Server Instance

CM13 Live

Revision

Origin: 1cb954c
Pull Request: a1cfb29
Server: 910975a

Test Merge Updated @ 07/26/2026 10:21:58 +00:00:

Server Instance

CM13 Live

Revision

Origin: 1cb954c
Pull Request: 8a685e1
Server: 203e41b

Test Merge Updated @ 07/26/2026 13:33:45 +00:00:

Server Instance

CM13 Live

Revision

Origin: 49a8f30
Pull Request: 8a685e1
Server: 9f106c0f595cb09f57d8d00ed79963bcbcdc55a7

Test Merge Updated @ 07/26/2026 14:04:39 +00:00:

Server Instance

CM13 Live

Revision

Origin: 354d433
Pull Request: 8a685e1
Server: ab4a0b09f57605a6e59b744481b832d0f6d9d285

Test Merge Updated @ 07/27/2026 03:09:56 +00:00:

Server Instance

CM13 Live

Revision

Origin: 7f13340
Pull Request: 8a685e1
Server: efdc8aa67d3add215c08013aec605d453652e32f

Test Merge Updated @ 07/27/2026 03:40:56 +00:00:

Server Instance

CM13 Live

Revision

Origin: 48b24b9
Pull Request: 8a685e1
Server: dfa8d7ec04acd422fe1ace94c7d284ee7782d336

Test Merge Updated @ 07/27/2026 12:15:52 +00:00:

Server Instance

CM13 Live

Revision

Origin: 59e45d0
Pull Request: 8a685e1
Server: bfa05d1

Test Merge Updated @ 07/27/2026 12:19:05 +00:00:

Server Instance

CM13 Live

Revision

Origin: 59e45d0
Pull Request: 8a685e1
Server: 4b858b9

Test Merge Updated @ 07/27/2026 12:41:33 +00:00:

Server Instance

CM13 Live

Revision

Origin: 59e45d0
Pull Request: 8a685e1
Server: 581861b

Test Merge Removed @ 07/27/2026 14:09:58 +00:00:

Server Instance

CM13 Live