Add onwner-info subchart#32
Closed
anton-paulovich wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Anton Paulovich <a.paulovich@sap.com>
anton-paulovich
force-pushed
the
feat/add-owner-info-subchart
branch
from
a1b55c8 to
2d8e82a
Compare
There was a problem hiding this comment.
Pull request overview
Adds the owner-info Helm subchart dependency to the owner-label-injector chart so that owner metadata can be produced in a way that satisfies the referenced Gatekeeper validation requirement.
Changes:
- Adds default
owner-infovalues (support-group,helm-chart-url) to the chart’svalues.yaml. - Bumps chart version to
2.3.1and addsowner-infoas a Helm dependency. - Introduces a
Chart.lockpinningowner-infoto1.0.0.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/owner-label-injector/values.yaml | Adds default configuration values for the new owner-info subchart. |
| charts/owner-label-injector/Chart.yaml | Bumps chart version and declares the owner-info dependency (OCI repo). |
| charts/owner-label-injector/Chart.lock | Pins the resolved owner-info dependency version/digest for reproducible builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+13
| dependencies: | ||
| - name: owner-info | ||
| repository: oci://keppel.eu-de-1.cloud.sap/ccloud-helm | ||
| version: '>= 0.0.0' |
Author
|
Wrong idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for gatekeeper validation rule