Skip to content

feat(alerts): enrich kube health alerts + sunset plutono#47

Merged
trouaux merged 6 commits into
mainfrom
enrich-alerts-sunset-plutono
Jun 19, 2026
Merged

feat(alerts): enrich kube health alerts + sunset plutono#47
trouaux merged 6 commits into
mainfrom
enrich-alerts-sunset-plutono

Conversation

@trouaux

@trouaux trouaux commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@trouaux trouaux requested a review from a team as a code owner June 19, 2026 07:47
Copilot AI review requested due to automatic review settings June 19, 2026 07:47
Signed-off-by: trouaux <thomas.rouaux@sap.com>
@trouaux trouaux force-pushed the enrich-alerts-sunset-plutono branch from 3c621b2 to 9390335 Compare June 19, 2026 07:48
Signed-off-by: trouaux <thomas.rouaux@sap.com>
@trouaux trouaux requested review from a team as code owners June 19, 2026 07:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Kubernetes Operations Helm chart to (1) enrich selected Kubernetes health alert expressions with optional kube-state-metrics labels and (2) remove legacy Plutono dashboards/templating while keeping Perses dashboards as the supported path.

Changes:

  • Add optional prometheusRules.kubeLabels configuration and Helm helpers to join kube_pod_labels / kube_deployment_labels into specific alert expressions.
  • Remove Plutono dashboard JSONs and the Plutono dashboard ConfigMap template; retain Perses dashboard selectors/config.
  • Bump chart and plugin definition versions to align with the updated bundle.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
charts/kubernetes-operations/values.yaml Adds prometheusRules.kubeLabels; removes Plutono selector values.
charts/kubernetes-operations/templates/_helpers.tpl Adds join helpers for optional alert label enrichment.
charts/kubernetes-operations/alerts/kubernetes-health.yaml Uses the new join helpers in selected alert expr blocks.
charts/kubernetes-operations/templates/dashboards.yaml Removes Plutono dashboard ConfigMap rendering template.
charts/kubernetes-operations/dashboards/nodes.json Removes legacy Plutono dashboard JSON.
charts/kubernetes-operations/dashboards/core-dns.json Removes legacy Plutono dashboard JSON.
charts/kubernetes-operations/dashboards/container-resources.json Removes legacy Plutono dashboard JSON.
charts/kubernetes-operations/dashboards/apiserver.json Removes legacy Plutono dashboard JSON.
charts/kubernetes-operations/plugindefinition.yaml Bumps plugin/chart versions (but needs option key updates—see comments).
charts/kubernetes-operations/Chart.yaml Bumps chart version and updates description/keywords away from Plutono.
Comments suppressed due to low confidence (1)

charts/kubernetes-operations/plugindefinition.yaml:24

  • spec.options still references Plutono and outdated values keys (prometheusRules.ruleSelector, dashboards.dashboardSelector). This no longer matches values.yaml (now prometheusRules.ruleSelectors and dashboards.persesSelectors) and conflicts with the Plutono sunset in this PR. Update the option names/descriptions (and consider exposing prometheusRules.kubeLabels too).
    version: 1.3.0
  options:
    - name: prometheusRules.create
      description: Create Prometheus rules
      required: false

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/kubernetes-operations/alerts/kubernetes-health.yaml Outdated
Comment thread charts/kubernetes-operations/alerts/kubernetes-health.yaml
Comment thread charts/kubernetes-operations/alerts/kubernetes-health.yaml
Comment thread charts/kubernetes-operations/templates/_helpers.tpl
Comment thread charts/kubernetes-operations/templates/_helpers.tpl Outdated
Signed-off-by: trouaux <thomas.rouaux@sap.com>
trouaux added 2 commits June 19, 2026 10:07
Signed-off-by: trouaux <thomas.rouaux@sap.com>
Signed-off-by: trouaux <thomas.rouaux@sap.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

charts/kubernetes-operations/plugindefinition.yaml:24

  • The PluginDefinition options still references Plutono and an outdated values key (prometheusRules.ruleSelector / dashboards.dashboardSelector). Since the chart has moved to Perses dashboards and uses prometheusRules.ruleSelectors + dashboards.persesSelectors, the current option names/descriptions will misconfigure the chart when set via Greenhouse. Update the option names/descriptions, and consider exposing the newly added prometheusRules.kubeLabels value here as well.
    version: 1.3.0
  options:
    - name: prometheusRules.create
      description: Create Prometheus rules
      required: false

Comment thread charts/kubernetes-operations/alerts/kubernetes-health.yaml Outdated
Comment thread charts/kubernetes-operations/templates/_helpers.tpl
Signed-off-by: trouaux <thomas.rouaux@sap.com>

@ibakshay ibakshay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@viennaa viennaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking and enriching.

@trouaux trouaux merged commit a6949e7 into main Jun 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants