feat(alerts): enrich kube health alerts + sunset plutono#47
Conversation
Signed-off-by: trouaux <thomas.rouaux@sap.com>
3c621b2 to
9390335
Compare
Signed-off-by: trouaux <thomas.rouaux@sap.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubernetes Operations Helm chart to (1) enrich selected Kubernetes health alert expressions with optional kube-state-metrics labels and (2) remove legacy Plutono dashboards/templating while keeping Perses dashboards as the supported path.
Changes:
- Add optional
prometheusRules.kubeLabelsconfiguration and Helm helpers to joinkube_pod_labels/kube_deployment_labelsinto specific alert expressions. - Remove Plutono dashboard JSONs and the Plutono dashboard ConfigMap template; retain Perses dashboard selectors/config.
- Bump chart and plugin definition versions to align with the updated bundle.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kubernetes-operations/values.yaml | Adds prometheusRules.kubeLabels; removes Plutono selector values. |
| charts/kubernetes-operations/templates/_helpers.tpl | Adds join helpers for optional alert label enrichment. |
| charts/kubernetes-operations/alerts/kubernetes-health.yaml | Uses the new join helpers in selected alert expr blocks. |
| charts/kubernetes-operations/templates/dashboards.yaml | Removes Plutono dashboard ConfigMap rendering template. |
| charts/kubernetes-operations/dashboards/nodes.json | Removes legacy Plutono dashboard JSON. |
| charts/kubernetes-operations/dashboards/core-dns.json | Removes legacy Plutono dashboard JSON. |
| charts/kubernetes-operations/dashboards/container-resources.json | Removes legacy Plutono dashboard JSON. |
| charts/kubernetes-operations/dashboards/apiserver.json | Removes legacy Plutono dashboard JSON. |
| charts/kubernetes-operations/plugindefinition.yaml | Bumps plugin/chart versions (but needs option key updates—see comments). |
| charts/kubernetes-operations/Chart.yaml | Bumps chart version and updates description/keywords away from Plutono. |
Comments suppressed due to low confidence (1)
charts/kubernetes-operations/plugindefinition.yaml:24
spec.optionsstill references Plutono and outdated values keys (prometheusRules.ruleSelector,dashboards.dashboardSelector). This no longer matchesvalues.yaml(nowprometheusRules.ruleSelectorsanddashboards.persesSelectors) and conflicts with the Plutono sunset in this PR. Update the option names/descriptions (and consider exposingprometheusRules.kubeLabelstoo).
version: 1.3.0
options:
- name: prometheusRules.create
description: Create Prometheus rules
required: false
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: trouaux <thomas.rouaux@sap.com>
Signed-off-by: trouaux <thomas.rouaux@sap.com>
Signed-off-by: trouaux <thomas.rouaux@sap.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
charts/kubernetes-operations/plugindefinition.yaml:24
- The PluginDefinition
optionsstill references Plutono and an outdated values key (prometheusRules.ruleSelector/dashboards.dashboardSelector). Since the chart has moved to Perses dashboards and usesprometheusRules.ruleSelectors+dashboards.persesSelectors, the current option names/descriptions will misconfigure the chart when set via Greenhouse. Update the option names/descriptions, and consider exposing the newly addedprometheusRules.kubeLabelsvalue here as well.
version: 1.3.0
options:
- name: prometheusRules.create
description: Create Prometheus rules
required: false
Signed-off-by: trouaux <thomas.rouaux@sap.com>
viennaa
left a comment
There was a problem hiding this comment.
Thanks for taking and enriching.
No description provided.