feat(thanos): template ingressClassName#1704
Open
trouaux wants to merge 3 commits into
Open
Conversation
Signed-off-by: trouaux <thomas.rouaux@sap.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Thanos Query Ingress templates to make ingressClassName configurable via Helm values, and bumps the chart version accordingly.
Changes:
- Template
spec.ingressClassNamefor Thanos Query HTTP and gRPC Ingress resources. - Update chart defaults/docs to reflect the
ingressClassNamebehavior. - Bump chart version from
0.10.0to0.10.1.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
thanos/charts/templates/query/ingress.yaml |
Makes Query HTTP Ingress ingressClassName value-driven (currently has a Helm rendering issue due to unquoted default). |
thanos/charts/templates/query/ingress-grpc.yaml |
Makes Query gRPC Ingress ingressClassName value-driven (currently uses wrong values key and has the same unquoted default issue). |
thanos/charts/values.yaml |
Sets thanos.query.ingress.ingressClassName default to nginx. |
thanos/README.md |
Updates documented default for thanos.query.ingress.ingressClassName to "nginx" (gRPC row likely needs alignment with template behavior). |
thanos/charts/Chart.yaml |
Chart version bump to 0.10.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trouaux
force-pushed
the
thanos-ingress-className
branch
from
fba4c72 to
a63bdc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.