udpate argora alerts according to metrics name#24
Open
adziauho wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Argora-related Prometheus alert expressions in the controlplane-remote ruleset to reflect renamed/updated metric names.
Changes:
- Switch
ArgoraUpdateInErrorto usekube_customresource_update_statusinstead ofkube_customresource_status_state. - Switch
ArgoraClusterImportInErrorto usekube_customresource_cluster_import_statusinstead ofkube_customresource_status_state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
you need to bump version in here: |
adziauho
force-pushed
the
update-argora-alerts-according-to-metrics-name
branch
from
6e5a379 to
d489f98
Compare
Signed-off-by: Aliaksei Dziauho <a.dziauho@sap.com>
Signed-off-by: Aliaksei Dziauho <a.dziauho@sap.com>
adziauho
force-pushed
the
update-argora-alerts-according-to-metrics-name
branch
from
d489f98 to
7262583
Compare
videlov
requested changes
Jun 18, 2026
Signed-off-by: adziauho <a.dziauho@sap.com>
videlov
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.