enable multiple features in analytic tokens#553
Draft
lbendavid-cloudinary wants to merge 1 commit intomasterfrom
Draft
enable multiple features in analytic tokens#553lbendavid-cloudinary wants to merge 1 commit intomasterfrom
lbendavid-cloudinary wants to merge 1 commit intomasterfrom
Conversation
lbendavid-cloudinary
requested review from
const-cloudinary,
magdakwiecien,
patrick-tolosa and
pawelphilipczyk-cloudinary
const-cloudinary
requested changes
Mar 15, 2023
const-cloudinary
left a comment
const-cloudinary
left a comment
There was a problem hiding this comment.
Does it preserve the order how the features where invoked?
I can see from the code that you just add them in a constant order.
As you know order matters.
It can provide useful information, for example when order is wrong or not optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for @cloudinary/url-gen
What does this PR solve?
enable creating feature flags for more than one feature in a single call
Final checklist