feat(stepper): add Stepper component - #830
Draft
mattrothenberg wants to merge 5 commits into
Draft
mattrothenberg wants to merge 5 commits into
mattrothenberg wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…emo layout Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move Stepper onto LayerDialog's layered frame: steps sit on the elevated gray and the active step lifts onto a white card, with actions on the frame. Add an experimental `fill="progress"` mode that fills white through the furthest step reached, `Stepper.Complete` with `reset()`, and gate `goToStep` on reached steps. Fix unhandled rejections from `beforeNext`, a loading flash on sync Next, vertical headers locking already-reached steps, and rail error states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Posted 3 inline findings. No additional actionable findings. Review notes
|
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 550 files, 1.51 MB packed, 6.99 MB unpacked.
|
Contributor
Visual contractsLinux Chromium references exercised by the PR's 1 curated contracttruncating text trigger
|
- Make collapsed vertical panels inert so hidden fields leave the tab order and accessibility tree while keeping the collapse animation. - Disable Next once the flow is complete so onComplete can't run twice. - Let Back leave the completion view of a one-step flow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
commit: |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://feat-stepper-layered-kumo-docs.design-engineering.workers.dev (commit e0b0fea)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Stepper, a multi-step flow component in LayerDialog's layered frame (vertical and horizontal).Open question: which fill? The docs page shows both:
fill="active"(default, only the current step is white) andfill="progress"(white fills through the furthest step reached). The prop goes away once we pick one.🤖 Generated with Claude Code