Skip to content

feat(chart): add y-axis minimum interval - #797

Merged
mattrothenberg merged 4 commits into
mainfrom
feat/timeseries-y-axis-min-interval
Sep 11, 2026
Merged

mattrothenberg merged 4 commits into
mainfrom
feat/timeseries-y-axis-min-interval

Conversation

@mattrothenberg

@mattrothenberg mattrothenberg commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Screenshot 2026-09-11 at 10 50 03 AM
  • add an opt-in yAxisMinInterval prop to TimeseriesChart
  • forward it to ECharts as minInterval
  • preserve the existing unconstrained default for every current consumer
  • add focused tests for both the opt-in and default behavior
  • document discrete count axes with an executable request-count example

Validation

  • pnpm vp fmt packages/kumo/src/components/chart/TimeseriesChart.tsx packages/kumo/src/components/chart/TimeseriesChart.test.tsx .changeset/silly-integers-relax.md

  • pnpm --filter @cloudflare/kumo exec vp test run src/components/chart/TimeseriesChart.test.tsx

  • pnpm --filter @cloudflare/kumo lint

  • pnpm --filter @cloudflare/kumo typecheck

  • pnpm --filter @cloudflare/kumo-docs-astro codegen:demos

  • pnpm --filter @cloudflare/kumo-docs-astro lint

  • pnpm --filter @cloudflare/kumo-docs-astro typecheck

  • pnpm changeset status

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: this is a small public API addition requiring maintainer API-design review.

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows:

  • Additional testing not necessary because:

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://feat-timeseries-y-axis-min-interval-kumo-docs.design-engineering.workers.dev (commit f18daf6)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://b75ef7a4-kumo-docs.design-engineering.workers.dev f18daf6 2026-09-11T14:40:24.434Z Visit the dashboard ↗
  • Build: In progress 🔵

View logs ↗
f0c7b1a 2026-09-11T14:27:19.063Z View logs ↗

@mattrothenberg mattrothenberg self-assigned this Sep 11, 2026
@ask-bonk

ask-bonk Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

LGTM!

Review notes
  • Confirming PR #797 and inspecting its changed chart implementation, tests, package conventions, and prior reviews before assessing the API behavior.
  • PR metadata matches the requested target and head SHA; there are no existing reviews to duplicate. The local checkout does not expose origin/main, so I am retrieving the commit diff directly and checking the chart wrapper and ECharts option typing before running the focused test.
  • The implementation exposes an optional numeric prop, preserves omission from the ECharts options by default, forwards 0 as well as positive values, and includes the prop in memo invalidation. The focused tests cover both configured and default option shapes; I am running them and validating the patch against its parent commit.
  • Patch validation completed: the commit changes only the three declared files and git diff --check reports no whitespace errors. The focused test could not run because pnpm is unavailable in this action environment; I am checking the PR’s recorded checks and dependency metadata as a substitute for local execution.
  • Recorded PR checks show format and changeset validation passing; build, type-oriented analysis, and package checks remain pending. No actionable correctness, API compatibility, accessibility, or test-coverage regressions were found in the reviewed diff.

github run

@mattrothenberg

Copy link
Copy Markdown
Collaborator Author

/bonk review and approve please

@ask-bonk

ask-bonk Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

LGTM!

Review notes
  • Confirmed the requested target is PR feat(chart): add y-axis minimum interval #797 and inspected its current metadata, diff, prior reviews, and inline comments.
  • Read the active review instructions plus the full TimeseriesChart implementation, test suite, and chart wrapper context.
  • Verified the optional prop is forwarded to ECharts, omitted by default, supports 0, and participates in option memoization; tests cover default and configured behavior.
  • git diff --check passed with a clean working tree.
  • Focused tests, lint, typecheck, and local format verification could not run because pnpm is unavailable. GitHub format and changeset checks are passing; remaining checks are pending.

github run

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@797

commit: f18daf6

@github-actions

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.0 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.8 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.8 KB
Chart (root) 218.7 KB 63.4 KB 54.7 KB
Chart (components/chart) 218.6 KB 63.3 KB 54.7 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.0 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.8 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 467.9 KB 349.2 KB

npm tarball: 535 files, 1.47 MB packed, 6.84 MB unpacked.

⚠️ 22 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: f18daf6e

@github-actions

Copy link
Copy Markdown
Contributor
Visual Regression Report — 29 changed, 16 unchanged

29 screenshot(s) with visual changes:

Button / Basic

431 px (0.49%) changed

Before After Diff
Before After Diff

Button / Variant: Secondary

567 px (0.64%) changed

Before After Diff
Before After Diff

Button / Variant: Ghost

175 px (0.2%) changed

Before After Diff
Before After Diff

Button / Variant: Destructive

1,518 px (1.71%) changed

Before After Diff
Before After Diff

Button / With Icon

256 px (0.29%) changed

Before After Diff
Before After Diff

Button / Loading State

841 px (0.95%) changed

Before After Diff
Before After Diff

Button / Disabled State

117 px (0.13%) changed

Before After Diff
Before After Diff

Button / Link as Button

820 px (0.93%) changed

Before After Diff
Before After Diff

Button / Link with Tooltip

748 px (0.84%) changed

Before After Diff
Before After Diff

Button / Disabled Link

763 px (0.86%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

404 px (0.46%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

1,625 px (1.83%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

1,735 px (1.96%) changed

Before After Diff
Before After Diff

Dialog / Custom Max Width

954 px (1.08%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

383 px (0.43%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

500 px (0.56%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

482 px (0.54%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

3,034 px (1.87%) changed

Before After Diff
Before After Diff

Select / Select Placement

4,084 px (2.82%) changed

Before After Diff
Before After Diff

Select / Select Dynamic Placement

3,296 px (3.17%) changed

Before After Diff
Before After Diff

Select / Select Without Label

664 px (0.75%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

237 px (0.27%) changed

Before After Diff
Before After Diff

Select / Select Loading

3,191 px (1.81%) changed

Before After Diff
Before After Diff

Select / Select Multiple

1,265 px (1.43%) changed

Before After Diff
Before After Diff

Select / Select Complex

181 px (0.17%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

1,457 px (1.65%) changed

Before After Diff
Before After Diff

Select / Select Long List

1,967 px (1.89%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
16 screenshot(s) unchanged
  • Button / Variant: Primary
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / Icon Only
  • Button / Title
  • Dialog / Dialog With Actions
  • Dialog / Dialog Sizes
  • Select / Select Basic
  • Select / Select With Description
  • Select / Select With Error
  • Select / Select With Tooltip
  • Select / Select Custom Rendering
  • Select / Select Disabled Options
  • Select / Select Disabled Items
  • Select / Select Grouped

Generated by Kumo Visual Regression

@mattrothenberg
mattrothenberg marked this pull request as ready for review September 11, 2026 14:50
@rozenmd
rozenmd self-requested a review September 11, 2026 17:12
@mattrothenberg
mattrothenberg merged commit 77489b5 into main Sep 11, 2026
19 of 20 checks passed
@mattrothenberg
mattrothenberg deleted the feat/timeseries-y-axis-min-interval branch September 11, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants