[inspector] Render ARef contents fully like normal values - #408
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Orchard’s inspector to treat clojure.lang.ARef values (e.g. atoms) more like “normal” values by rendering the deref’ed contents using the standard inspection pipeline, including paging and metadata display.
Changes:
- Extend pagination detection to consider an ARef pageable when its deref’ed value is a pageable collection.
- Render ARef deref sections by recursively invoking the normal
inspectimplementation on the deref’ed value (enabling paging/meta rendering there). - Update/expand inspector tests for atoms (including paging behavior and identity hash code output) and add a changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/orchard/inspect_test.clj |
Updates atom-related expectations to match new ARef rendering, including paging and identity hash code output. |
src/orchard/inspect.clj |
Implements ARef-aware pagination and switches ARef deref rendering to use the standard inspection pipeline. |
CHANGELOG.md |
Documents the user-visible inspector change for ARef rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables paging and meta rendering for values inside an ARef (e.g. an atom). Makes it easier to jump directly to a subvalue from an atom, and overall puts less need on derefing before inspecting.