Skip to content

[inspector] Render ARef contents fully like normal values - #408

Merged
alexander-yakushev merged 1 commit into
masterfrom
aref
Jul 4, 2026
Merged

[inspector] Render ARef contents fully like normal values#408
alexander-yakushev merged 1 commit into
masterfrom
aref

Conversation

@alexander-yakushev

@alexander-yakushev alexander-yakushev commented Jul 4, 2026

Copy link
Copy Markdown
Member

This change enables paging and meta rendering for values inside an ARef (e.g. an atom). Makes it easier to jump directly to a subvalue from an atom, and overall puts less need on derefing before inspecting.


  • You've added tests to cover your changes.
  • You've updated the changelog (if adding/changing user-visible functionality)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Orchard’s inspector to treat clojure.lang.ARef values (e.g. atoms) more like “normal” values by rendering the deref’ed contents using the standard inspection pipeline, including paging and metadata display.

Changes:

  • Extend pagination detection to consider an ARef pageable when its deref’ed value is a pageable collection.
  • Render ARef deref sections by recursively invoking the normal inspect implementation on the deref’ed value (enabling paging/meta rendering there).
  • Update/expand inspector tests for atoms (including paging behavior and identity hash code output) and add a changelog entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/orchard/inspect_test.clj Updates atom-related expectations to match new ARef rendering, including paging and identity hash code output.
src/orchard/inspect.clj Implements ARef-aware pagination and switches ARef deref rendering to use the standard inspection pipeline.
CHANGELOG.md Documents the user-visible inspector change for ARef rendering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/orchard/inspect.clj
Comment thread src/orchard/inspect.clj
@alexander-yakushev
alexander-yakushev merged commit 2845519 into master Jul 4, 2026
16 checks passed
@alexander-yakushev
alexander-yakushev deleted the aref branch July 4, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants