Skip to content

Add missing @types for spdx deps#59

Merged
JamieMagee merged 1 commit intomasterfrom
add-spdx-type-definitions
Apr 9, 2026
Merged

Add missing @types for spdx deps#59
JamieMagee merged 1 commit intomasterfrom
add-spdx-type-definitions

Conversation

@JamieMagee
Copy link
Copy Markdown
Contributor

spdx-expression-parse, spdx-license-ids, and spdx-satisfies were missing their @types packages. Adds them as devDependencies.

@JamieMagee JamieMagee requested a review from qtomlinson April 9, 2026 04:19
Copy link
Copy Markdown
Contributor

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prep work! One thing to keep in mind for the index.js → index.ts conversion: these @types packages describe the upstream APIs, but we use ClearlyDefined forks (clearlydefined/spdx-expression-parse.js and clearlydefined/spdx-satisfies.js) that diverge from them. We may need module declaration overrides or local augmentations when we actually convert index.js to TypeScript.

@JamieMagee
Copy link
Copy Markdown
Contributor Author

Yeah, I am aware of the forks. The @types/ packages aren't enforcing anything at the moment, as index.js hasn't been converted to TypeScript. I'll cross that bridge once I figure out what to do with this library as part of the TypeScript migration.

@JamieMagee JamieMagee merged commit d7d27c4 into master Apr 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants