Implement Security Suite group 6#2224
Conversation
e862266 to
448346a
Compare
adhilto
left a comment
There was a problem hiding this comment.
I've just review 6.1 so far, but some initial feedback:
We need to check the recipients of a policy to make sure it applies to all recipients. For example, I made it so that the strict preset policy applies to only me and no one else, and 6.1 passed. It should check the other policies in this case because the strict policy isn't really active. Devesh added some helper functions that can help with this:
- To check if a preset policy covers everyone:
- To check if a custom policy covers everyone:
- No need to check this for the default policy as this applies to all
…e HighConfidencePhishAction doesn't support the delete operation
… checks to preset/custom filter policies check
…ulting in non-compliant state
bcd27a8 to
ca026e3
Compare
|
@JosephRWalter Resolved the issue with the |
JosephRWalter
left a comment
There was a problem hiding this comment.
I retested the functional tests locally, everything passed as expected. I also tested all of the products against the 4 tenants using both interactive and non-interactive logins, ScubaGear executed as expected.
No issues.
🗣 Description
Implements Security Suite group 6 for Inbound Anti-Spam Protections policies. Rego rulesets were added that handle default, standard/strict presets, and custom policies. It also handles the precedence for how the anti-spam policies are checked: strict preset -> standard preset -> custom -> default. New rego unit tests and functional tests are included as well.
💭 Motivation and context
Closes #2107
🧪 Testing
Tested against all four test tenants, modified different email classifications to check pass/fail states for Security Suite 6.1 and 6.2.
Run unit tests locally:
Run functional tests locally:
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
PR/feature branch passes functional tests for relevant products, if applicable.
Feature branch has been rebased against changes from parent branch, as needed.
Use
Update branchbutton below or use this reference to rebase from the command line.Resolved all merge conflicts on branch.
Squash all commits into one PR level commit using the
Squash and mergebutton.✅ Post-merge checklist