Skip to content

fix(quake): reject nodes without subnets #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kriss39 wants to merge 2 commits into from
Closed

fix(quake): reject nodes without subnets #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c3776
fix(quake): reject nodes without subnets
kriss39 Sep 12, 2026
32aab10
test(quake): cover empty subnet manifests
kriss39 Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/quake/src/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,12 @@ impl Manifest {
bail!("At least one node must be defined");
}

for node_name in self.nodes.keys() {
if self.subnets.subnets_of(node_name).is_empty() {
bail!("Node '{node_name}' must belong to at least one subnet");
}
}

if let Some(gb) = self.node_disk_gb {
if gb < MIN_DISK_GB {
bail!("node_disk_gb must be at least {MIN_DISK_GB} (got {gb})");
Expand Down
17 changes: 17 additions & 0 deletions crates/quake/src/manifest/raw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,23 @@ mod tests {

use super::*;

#[test]
fn test_empty_node_subnets_are_rejected() {
let toml = r#"
[nodes.validator1]
subnets = ["trusted"]

[nodes.full1]
subnets = []
"#;

let err = Manifest::from_string(toml).unwrap_err().to_string();
assert!(
err.contains("Node 'full1' must belong to at least one subnet"),
"unexpected error: {err}"
);
}

/// el.config.trusted_peers round-trips through RawManifest → Manifest → RawManifest → Manifest.
#[test]
fn test_el_trusted_peers_roundtrip() {
Expand Down