chore(evm-node): remove stale chain-spec FIXME - #376
Conversation
`crates/evm-node/src/node.rs` carries:
// FIXME use the ethereum chain spec temporary, we need to define Arc chain spec
// original traits for ChainSpec in this file `Hardforks + EthereumHardforks + EthExecutorSpec`
Arc's chain spec already exists and this file already uses it: `ArcChainSpec`
is defined in `crates/execution-config/src/chainspec.rs` and node.rs binds
`ChainSpec = ArcChainSpec` throughout. That was already true in the first
public commit (a1235c0), where node.rs used `ArcChainSpec` 10 times — so the
FIXME has been stale since it landed.
The second line documented the upstream reth file's ChainSpec bounds and only
made sense as a continuation of the FIXME, so it goes too.
Comments only; no behaviour change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@ZhiyuCircle when you have a moment — this is the same shape as #307 (a stale FIXME, comments only, no behaviour change), and its workflow run is waiting on first-time-contributor approval. Thanks! |
|
Small, low-risk PR — verified both claims directly rather than taking the description at its word.
|
Summary
Remove the stale
FIXME use the ethereum chain spec temporary, we need to define Arc chain specincrates/evm-node/src/node.rs.ArcChainSpecis defined incrates/execution-config/src/chainspec.rsand node.rs already bindsChainSpec = ArcChainSpecthroughout — as it did in the first public commit.The line after it documented the upstream reth file's ChainSpec bounds and only made sense as the FIXME's continuation, so it goes too; happy to keep it as a standalone porting note if preferred.
Fixes #375.
Test plan
cargo fmt --all --checkclean