[PF-18] PlanForge rules prefix, doctor rule checks, and static doctor exit - #32
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
planforge-filename prefix and ensure they are installed on init and checked by doctor..planforge/plansand references; add explicit process exit after static doctor checks.Description
Rule naming and templates
workflow.mdc→planforge-workflow.mdcin.cursor/rulesandtemplates/cursor/rules.planforge-cursor-agent-terminal.mdc(timeout guidance for plan/implement) to templates and to.cursor/rules; content in English.Doctor
planforge-workflow.mdc(no longerworkflow.mdc) in both cli-js and cli-py..cursor/rules/planforge-workflow.mdcand.cursor/rules/planforge-cursor-agent-terminal.mdc; missing → warn with "run planforge install".process.exit(0)(cli-js) andsys.exit(0)(cli-py) when there is no error; existingexit(1)on error unchanged.Templates and repo
packages/cli-js/scripts/check-templates.js: required list updated toplanforge-workflow.mdcandplanforge-cursor-agent-terminal.mdc(replacingworkflow.mdc)..planforge/plans/and.planforge/plans/index.json; removed.planforgefrom skip lists and glob excludes inpackages/cli-js/src/utils/repo-context.ts.planforge-workflow.mdc,planforge-cursor-agent-terminal.mdc; deletedworkflow.mdc,cursor-agent-terminal.mdcpackages/cli-js/src/commands/doctor.ts,packages/cli-py/planforge/commands/doctor.pypackages/cli-js/scripts/check-templates.js,templates/cursor/rules/*packages/cli-js/src/utils/repo-context.tsHow to test
planforge doctor static(orplanforge doctorin a non-TTY) and confirm the process exits with code 0 when all checks pass, and with code 1 when any check has status error..cursor/rules/planforge-workflow.mdcand.cursor/rules/planforge-cursor-agent-terminal.mdc(ok if present, warn + "run planforge install" if missing).planforge installin a test project and verify.cursor/rules/planforge-workflow.mdcandplanforge-cursor-agent-terminal.mdcare created.packages/cli-js, runpnpm run check:templatesand confirm it passes (required templates include the two planforge rule files).planforge doctor ai) and confirm workflow content is still loaded fromplanforge-workflow.mdc.Review Requirement
workflow.mdcor creates.planforge/plans.Additional Info