[PF-21] Strengthen append-i18n prompt for plan language detection - #28
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Clarify how the plan’s output language is chosen so that code snippets and technical identifiers (often in English) do not cause the plan to be written in English when the user’s main language is something else (e.g. Korean).
Description
packages/core/prompts/append-i18n.mdNotion (다국어 지원)
Documented this change in a new section “4. 계획서 언어 결정(append-i18n) 보강” (background, rules table, and modified file).
How to test
function foo()).Review Requirement
append-i18n.mdare clear and that the “exclude code/identifiers” rule is easy to apply for model behavior.Additional Info