[PF-19] Rollback to .cursor/plans and .cursor/contexts with HHMM-slug plan filenames - #27
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Roll back plan and context storage from
.planforge/plansand.planforge/contextsto.cursor/plansand.cursor/contextsso that opening a*.plan.mdfile in Cursor shows the Build button (which only appears for files under.cursor). Unify plan filenames to {HHMM}-{slug}.plan.md (time 24h + slug, hash removed) and drop legacy support (.planforge path detection, migration warnings,getLegacyContextDir) to keep the codebase simple.Description
Paths
packages/cli-js/src/utils/paths.ts:getPlansDir→.cursor/plans,getContextsDir→.cursor/contexts.getProjectRootnow treatsplanforge.jsonor.cursor/plans/.cursor/contextsas root (.planforgeroot marker removed).getLegacyContextDirremoved.getDatePartsextended withhhmm(HHMM).packages/cli-py/planforge/utils/paths.py: Same path changes;get_legacy_context_dirremoved;get_date_partsreturns(yyyy_mm_dd, mmdd, hhmm).Plan command (filename rule)
packages/cli-js/src/commands/plan.ts: Plan file name changed fromMMDD-{slug}-{hash}.plan.mdto{HHMM}-{slug}.plan.md.shortHash()andrandomBytesimport removed.packages/cli-py/planforge/commands/plan.py: Same;_short_hash()andsecretsimport removed;get_date_partsnow used forhhmm.Init
packages/cli-js/src/commands/init.ts: Creates.cursor/plansand.cursor/contexts; messages updated. No legacy migration option.packages/cli-py/planforge/commands/init.py: Same.Doctor
packages/cli-js/src/commands/doctor.ts: Checks only.cursor/plansand.cursor/contexts; labels updated; legacy block removed (nogetLegacyContextDir, no legacy context or flat-plan warnings).packages/cli-py/planforge/commands/doctor.py: Same;get_legacy_context_dirimport and legacy checks removed.Docs and rules
.cursor/rules/workflow.mdc,.cursor/skills/p/SKILL.md,.cursor/skills/i/SKILL.md: Paths updated to.cursor/plans/YYYY-MM-DD/{HHMM}-<summary>.plan.md,.cursor/contexts; context filenames described asHHMM-....templates/cursor/: Same updates inrules/workflow.mdc,skills/p/SKILL.md,skills/i/SKILL.md..cursor(reopen file or runplanforge implement).--context-dirhelp text updated to.cursor/plans,.cursor/contexts.Migration
.planforge. Manual migration only (documented in README): copy.planforge/plans→.cursor/plans/,.planforge/contexts→.cursor/contexts/, rename files to{HHMM}-{slug}.plan.md, updateindex.json.How to test
planforge init(or use existing project withplanforge.json). Confirm it creates.cursor/plansand.cursor/contextsand prints "Created .cursor/plans", "Created .cursor/contexts".planforge plan "add login page". Confirm the plan file is created under.cursor/plans/YYYY-MM-DD/with filename like1430-add-login-page.plan.md(HHMM-slug, no hash)..plan.mdfile in Cursor and confirm the Build button appears (top right).planforge doctor. Confirm it reports.cursor/plansand.cursor/contextsonly; no legacy path warnings.planforge implement "implement the login form"and confirm it uses the active plan from.cursor/plans/index.jsonand context from.cursor/contexts.Review Requirement
.cursor/plansand.cursor/contextsand that project root detection no longer depends on.planforge.getLegacyContextDir/get_legacy_context_diror legacy migration logic in doctor/init.Additional Info
.cursor/plans,.cursor/contexts) for Build button; date subfolders (YYYY-MM-DD) kept; filename rule set to{HHMM}-{slug}.plan.md; legacy support intentionally dropped.