[PF-8] Run plan and implement in Cursor agent sandbox with streaming - #23
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Run plan and implement in the Cursor agent sandbox (foreground) with streaming so that provider (Codex/Claude) logs stream in the same terminal and encoding issues in an external terminal are avoided.
Description
runPlannow usesrunCodexExecStreaming(fullPrompt, cwd, true); ClauderunPlanusesrunClaudeStreaming(fullPrompt, cwd)instead ofexecSync. Provider stdout/stderr stream to the agent terminal._run_claude_streamingand_run_codex_exec_streaming;run_planuses them so output streams tosys.stdout/sys.stderrvia threads.templates/cursor/rules/workflow.mdcandtemplates/cursor/skills/i/SKILL.md(and skill p if touched) for install sync.How to test
planforge plan "Add a README section"(or use/pin Cursor with a goal). Confirm that Codex or Claude output appears incrementally in the same terminal (no long silence until the end).planforge implement "Add a README section"(or use/iin Cursor). Confirm that the command runs in the same terminal, output streams, and the run completes before the agent replies (no "running in the terminal" early exit). Check that non-ASCII characters (e.g. Korean) in logs are not garbled..cursor/skills/p/scripts/run_plan.ps1 "goal"and.cursor/skills/i/scripts/run_implement.ps1 "prompt"from the repo root and confirm behavior matches.Review Requirement
Additional Info
feature/PF-8.