Lower jscpd minTokens from 50 to 45 to identify more duplication #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add expectNoStaleExceptions helper to code-scanner.js for DRY stale validation - Update null-checks, let-usage, object-mutation tests to use new helper - Refactor config.test.js to verify DEFAULTS keys instead of duplicating values - Extract shared .quote-checkout-summary/.hire-dates-section styles to style.scss Reduces clone count from 21 to 16 at 45-token threshold.
- quote-steps: Data-driven updateButtons tests + setupQuoteStepsNav helper - unused-images: expectLogContains/expectAllImagesUsed curried assertions - guides: guide() factory function for test data creation Reduces clone count from 16 to 7 at 45-token threshold.
- Extract expectLogContains to test-utils.js for reuse - Add guides() helper using map for cleaner test data creation
Add getToday(), createHireDatesHtml(), withHireTestSetup(), and initHireWithCallback() helpers to reduce test duplication. Eliminates repeated date calculations and DOM setup code across multiple tests.
Refactor addFile and addMarkdown tests to use existing withTestSite helper instead of manual try/finally cleanup. Extract common page config to minimalPage() factory function.
Add typeSizeData() factory for common type/size filter configuration. Add categorizedProducts() factory for products with category setups. Reduces test duplication by reusing shared fixtures.
Add runEleventyAfter() helper in unused-images tests to share the config/handler/logging setup. Add lunchMenuWithItem() factory in pdf tests for dietary key test cases. Eliminates remaining jscpd clones at minTokens=45.
- Replace forEach with for...of in quote-steps data-driven tests - Inline createHireDatesHtml into withHireTestSetup - Update test-hygiene allowlist with new test helpers - Fix stale line numbers in code-quality-exceptions
The curried expectLogContains helper was overengineered for a single use case. Replace with a simple inline assertion in the test file.
Test that stale exception entries are logged before the assertion fails. Uses expect().toThrow() to avoid needing a try/catch block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.