Skip to content

ci: merge workflows#61

Open
umarcor wants to merge 1 commit into
chipsalliance:masterfrom
umarcor:ci/merge
Open

ci: merge workflows#61
umarcor wants to merge 1 commit into
chipsalliance:masterfrom
umarcor:ci/merge

Conversation

@umarcor

@umarcor umarcor commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

Ref #54

As a first step towards understanding the differences between workflows, all of them are merged. The three of them are triggered by the same events anyway...

Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>

@litghost litghost left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge if green

@litghost litghost requested a review from mithro February 19, 2021 17:06
@mithro

mithro commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

I actually think that #64 will probably replace this pull request?

@umarcor

umarcor commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

Not as is now, but yes, #64 can easily include this change. The point is not to have multiple workflows with the same events (on field). That's only useful if you/we want independent shields/badges. Otherwise, having them together is easier to navigate.

I subscribed to #64 and I will keep this just as a remainder for myself until that's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants