Remove stale brakeman gem dependency - #3406
Merged
Merged
Conversation
Brakeman 5.4.1 was declared in group :development but was never actively used. The CI security scanning workflow (brakeman-analysis.yml) independently installs its own pinned version (5.0.4) via gem install and does not use the Gemfile entry at all. Removing to: - Eliminate ambiguity around the Brakeman Public Use License - Prevent accidental local installation by developers - Remove BlackDuck/dependency scan false positive for 5.4.1 The brakeman-analysis.yml workflow is unaffected and continues to run Brakeman 5.0.4 independently on GitHub-hosted runners. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: RoyShravani <shravani.roy@progress.com>
RoyShravani
added
the
ai-assisted
Brakeman is fully replaced by CodeQL (org-level default setup) which already runs Analyze (ruby) on every PR. Removing eliminates the Brakeman Public Use License commercial use question entirely. Files removed: - .github/workflows/brakeman-analysis.yml - src/supermarket/config/brakeman.ignore Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: RoyShravani <shravani.roy@progress.com>
Ubuntu 16.04 reached End of Life in April 2021. Its GLIBC 2.23 is incompatible with ffi 1.17.4+ which requires GLIBC 2.27+, causing build failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: RoyShravani <shravani.roy@progress.com>
Contributor
Author
saghoshprogress
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the stale
brakemangem entry fromGemfileandGemfile.lock.Why
brakeman 5.4.1entry ingroup :developmentwas never actively used.github/workflows/brakeman-analysis.yml) independently installs its own pinned version (5.0.4) viagem installand does not reference the Gemfile at allbundle config set without 'development doc', so it was never distributedWhat is unaffected
brakeman-analysis.ymlsecurity scan workflow continues to run unchanged — it installs Brakeman 5.0.4 independently on GitHub-hosted runnersChanges
src/supermarket/Gemfile— removedgem "brakeman"fromgroup :developmentsrc/supermarket/Gemfile.lock— removed correspondingbrakeman (5.4.1)entries