Repository navigation
fix: Hindi/Hinglish approval answers cite the source, never splice it - #92
Merged
Merged
Conversation
REVIEW-2026-11-11 P0: "The finance approval from November 2 में मंज़ूरी दर्ज है of $42,000" - English record labels spliced into Hindi grammar. The four HI and four HL templates now keep record text, values, negation and dates verbatim and trail the source as (स्रोत: X) / (source: X). docLabel/docLabelOf strip ":" from titles so the "Per <label>:" citation delimiter is unambiguous by construction. RED on base: vernacular tests #9, #10, #14 fail; GREEN 14/14 with the fix. Full battery green: main 341, boundaries 302, evaluation 536, ingest 51, clinical 119, vault, graph, browser/UI checks, ingest bench 131/131.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Paraphrase bench (32d72c8, Xenova/bge-small-en-v1.5@q8, dense on){
"development": {
"n": 15,
"keyword": {
"recall1": 0.333,
"recall3": 0.4,
"abstain": 0.4
},
"hybrid": {
"recall1": 0.467,
"recall3": 0.533,
"abstain": 0.4
},
"dense": {
"recall1": 0.4,
"recall3": 0.8
},
"nAbstain": 5,
"units": {
"instructed": {
"recall1": 0.267,
"recall3": 0.8
},
"plain": {
"recall1": 0.4,
"recall3": 0.8
}
}
},
"heldout": {
"n": 15,
"keyword": {
"recall1": 0.333,
"recall3": 0.333,
"abstain": 0.8
},
"hybrid": {
"recall1": 0.333,
"recall3": 0.333,
"abstain": 0.8
},
"dense": {
"recall1": 0.533,
"recall3": 0.867
},
"nAbstain": 5,
"units": {
"instructed": {
"recall1": 0.467,
"recall3": 0.733
},
"plain": {
"recall1": 0.4,
"recall3": 0.733
}
}
},
"tuning": {
"instructed": {
"chosenOnDevelopment": {
"minCosine": 0.56,
"minMargin": 0.02
},
"development": {
"right": 1,
"wrong": 0,
"falseAccept": 0,
"recall1WithRescue": 0.533
},
"heldout": {
"right": 2,
"wrong": 1,
"falseAccept": 0,
"recall1WithRescue": 0.467
}
},
"plain": {
"chosenOnDevelopment": {
"minCosine": 0.605,
"minMargin": 0
},
"development": {
"right": 1,
"wrong": 0,
"falseAccept": 0,
"recall1WithRescue": 0.533
},
"heldout": {
"right": 1,
"wrong": 1,
"falseAccept": 0,
"recall1WithRescue": 0.4
}
}
},
"shipped": {
"gate": {
"minCosine": 0.72,
"minMargin": 0.02,
"agree": 0.5
},
"development": {
"right": 0,
"wrong": 0,
"falseAccept": 0,
"recall1WithRescue": 0.467
},
"heldout": {
"right": 0,
"wrong": 0,
"falseAccept": 0,
"recall1WithRescue": 0.333
}
},
"units": 25
}Per question: split | kind | hybrid top-1 hit | top-3 dense cosine (* = right passage) | unit cosine/margin | question
Shipped discovery gate {"minCosine":0.7,"minMargin":0.03,"lexTop":3}
Calibration: no rule reaches 90% right with <= 10% absent shown on dev
Cross-encoder rerank of the fused top 20 (Xenova/ms-marco-MiniLM-L-6-v2)
Reranker gate: no reranker rule reaches 90% right with <= 10% absent shown on dev
Cross-encoder rerank of the fused top 20 (jinaai/jina-reranker-v1-tiny-en)
Reranker gate: no reranker rule reaches 90% right with <= 10% absent shown on dev
Hybrid retrieval A/BBare chunk embeddings: Contextual chunk headers: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEW-2026-11-11 P0 ("Hindi template splice"):
The finance approval from November 2 में मंज़ूरी दर्ज है of $42,000— English record labels spliced into Hindi sentence grammar.Fix (citation-splice only)
src/conversation.mjs) and four HL (src/vernacular.mjs) templates now keep record text, values, negation and dates verbatim and trail the source as a citation:(स्रोत: X)/(source: X).Yes. X records the approval (of Y).split into two ordered templates so the broad(.*)suffix capture can't mangle the value.docLabel()(src/spoken.mjs, now exported) anddocLabelOf()(src/spoken-routes.mjs) strip:from titles, so thePer <label>:citation delimiter is unambiguous by construction. New regression test pins the contract end to end.No who-answer, claim-status, actor or gloss behaviour changes.
Evidence