Skip to content

Reduce complexity#131

Open
oliverfoster wants to merge 4 commits intoissue/119from
issue/119-b
Open

Reduce complexity#131
oliverfoster wants to merge 4 commits intoissue/119from
issue/119-b

Conversation

@oliverfoster
Copy link
Copy Markdown
Member

@oliverfoster oliverfoster commented Apr 14, 2026

extension to #122

Fix

  • Simplified relative container positioning (Change from fixed to absolute, put annotation in correct parent)
  • Simplified event attachment (No need to popup checking as dom modifier does that, switch to animation/transition end)
  • Reduced recalculations (Chained isVisible, isReadable in &&, so that they only happen when the other fails)
  • Reduced dom modifications (Added hashing for previous vs next state)
  • Reduced duplicate functionality and clarified (shouldAnnotate, isVisible, etc)
  • Add fix for nav buttons, where their small + hard-top nature makes for annotation positioning issues.

Copy link
Copy Markdown
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice @oliverfoster - works as expected thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants