Rename AuthError to ServerAuthError and add BrowserAuthError#40
Closed
cfuehrmann wants to merge 2 commits into
Closed
Rename AuthError to ServerAuthError and add BrowserAuthError#40cfuehrmann wants to merge 2 commits into
cfuehrmann wants to merge 2 commits into
Conversation
- Rename AuthError to ServerAuthError in @repo/fido2-auth to clarify it's server-side - Add BrowserAuthError in web demo for client-side WebAuthn errors - Add toBrowserAuthError() utility to convert browser errors - Update all UI error handling to use the new error types - Standardize error message to 'Cancelled or timed out' across all pages
Replace the BrowserAuthError class with a simpler function that just returns the error code directly. The class added indirection without providing additional value for the current usage pattern.
Owner
Author
|
Closing: after discussion, the refactoring doesn't add enough value to justify the indirection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves error handling by clearly separating server-side and browser-side authentication errors:
@repo/fido2-auth): Errors from the auth service on the server (username taken, user not found, etc.)This separation clarifies which world each error type lives in, which is important if the auth package is later wrapped behind a JSON/HTTP API and called from different technology stacks.
Changes
@repo/fido2-authpackageAuthErrortoServerAuthErrorAuthErrorCodetoServerAuthErrorCodeWeb demo
BrowserAuthErrorclass with codes:CANCELLED_OR_DENIED,ALREADY_REGISTEREDtoBrowserAuthError()utility to convert WebAuthn errors