Type authenticatorResponse in services.ts, cast at server.ts boundary#37
Merged
Merged
Conversation
…eJSON in services.ts
1a902dc to
43f88ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authenticatorResponseparameter properly inservices.tsusingRegistrationResponseJSON/AuthenticationResponseJSONfrom@simplewebauthn/serverunknown→ typed cast toserver.tswhere the public API boundary (unknown) meets the typed internalsas anycasts and theireslint-disablecomments fromservices.tsRationale
server.ts(createAuthpublic API) staysunknownto avoid coupling consumers to@simplewebauthn/servertypes. Butservices.tsis internal to the auth package and already depends on@simplewebauthn/servertransitively — so it should be properly typed. The casts now live at the correct boundary inserver.ts.Files changed (2)
packages/fido2-auth/src/services.ts— proper types, no moreas anypackages/fido2-auth/src/server.ts—as RegistrationResponseJSON/as AuthenticationResponseJSONat boundaryChecks