Split login/register into separate routes#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/loginpage into separate/loginand/registerroutesgetErrorMessageutility tosrc/lib/errors.tsLinkcomponents for navigation between routesWhy
The login page used conditional rendering (
showRegistrationstate) to toggle between login and registration views. Separate routes are better:/registerChanges
src/lib/errors.tsgetErrorMessageshared by both pagessrc/app/(auth)/register/page.tsxsrc/app/(auth)/login/page.tsxtests/e2e/auth.spec.ts/registerinstead of clicking through/loginThe "can toggle between login and registration views" test is replaced with "login page links to register and vice versa" which verifies the Link navigation between routes.
All checks pass: build, lint, format, knip, unit tests, 11/11 e2e tests.