cephadm-preflight: add cephadm_preflight_manage_firewall skip option - #373
cephadm-preflight: add cephadm_preflight_manage_firewall skip option#373kishore-kumar-dev wants to merge 1 commit into
Conversation
|
Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run. |
4 similar comments
|
Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run. |
|
Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run. |
|
Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run. |
|
Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run. |
b9e0050 to
58acbea
Compare
|
Hi @pdvian @asm0deuz — could you please review when you have a moment? This addresses tracker #76709. I reproduced the issue in a lab environment Compared to #371, this PR keeps default behavior unchanged (firewalld still Thanks! |
a46a8d4 to
2d2e781
Compare
2d2e781 to
fbe6ecc
Compare
The preflight playbook unconditionally enables and starts firewalld during host preparation. In deployments where host-level firewalls are intentionally disabled, this can disrupt inter-node Ceph connectivity during upgrade pre-checks. Add cephadm_preflight_manage_firewall (default true) so administrators can skip firewalld management without editing the playbook. The ceph_defaults_preflight_manage_firewall variable follows the existing ceph_defaults_* naming convention, with a backward-compatibility alias for cephadm_preflight_manage_firewall. Fixes: https://tracker.ceph.com/issues/76709 Signed-off-by: Kishore Kumar <kishorekumar21ns@gmail.com>
|
Reopening: PR was closed inadvertently after a force-push during commit cleanup. Branch restored with changes intact. |
Problem
cephadm-preflight.ymlunconditionally enables and startsfirewalldduring host preparation. In deployments where host-level firewalls are
intentionally disabled, running preflight during an upgrade can disrupt
inter-node Ceph connectivity.
Solution
Gate the firewalld task behind
cephadm_preflight_manage_firewall(default
true) so administrators can skip host firewall management:Implementation details:
ceph_defaults_preflight_manage_firewallinternally (repo convention)cephadm_preflight_manage_firewallvia backward-compatibility aliastruepreserves existing preflight behavior unless explicitly skippedREADME.mdRelated issues
Fixes: https://tracker.ceph.com/issues/76709
Note on #371
PR #371 proposes a similar change with
configure_firewallddefaulting tofalse(opt-in). This PR defaults totrue(opt-out) to avoid changingbehavior for deployments that rely on preflight enabling firewalld. Happy to
align on the default with maintainers during review.
Test plan
cephadm_preflight_manage_firewall=false: task skipped, firewalld unchangedcephadm_preflight_manage_firewall=true: firewalld enabled (default path)cephadm-ansible PR Pipeline(needs maintainerok to test)