Little bit refactoring cors to separate module, add auth0 config example#83
Merged
laskoviymishka merged 15 commits intocentralmind:mainfrom Jul 9, 2025
Merged
Little bit refactoring cors to separate module, add auth0 config example#83laskoviymishka merged 15 commits intocentralmind:mainfrom
laskoviymishka merged 15 commits intocentralmind:mainfrom
Conversation
…-tool-descriptions-in-gateway.yaml Fix missing tool descriptions
Signed-off-by: Slach <bloodjazman@gmail.com>
Add cors to sse
Contributor
|
Thanks for your contributions! It's a bit rude question, but is it possible to split this one in stacked pr so it would be easier to review? |
laskoviymishka
requested changes
Jun 19, 2025
Contributor
laskoviymishka
left a comment
laskoviymishka
left a comment
There was a problem hiding this comment.
overall LGTM, once this couple tiny piece are done - safe to merge.
|
|
||
| // ApplyCORSHeaders adds the standard CORS headers to a response | ||
| // For handlers that are not wrapped in middleware | ||
| func ApplyCORSHeaders(w http.ResponseWriter, allowedMethods string) { |
Contributor
There was a problem hiding this comment.
cors.ApplyCORSHeaders -> cors.ApplyHeaders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Agreement
By submitting this pull request, I affirm that: