feat: Add docs maintainer and Celestia router skills#2427
feat: Add docs maintainer and Celestia router skills#2427
Conversation
Summary of ChangesHello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces two new "skill" definitions to streamline development and documentation processes within the Celestia project. One skill provides detailed guidelines for maintaining the Celestia documentation site, ensuring consistency and accuracy. The other establishes a routing mechanism to direct broad Celestia tasks to the appropriate repository, clarifying ownership and preventing misdirected effort. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🚀 Preview Deployment Your preview is ready: https://celestiaorg.github.io/docs-preview/pr-2427/ |
There was a problem hiding this comment.
Code Review
This pull request introduces two new "skill" definition files, celestia-docs-maintainer and celestia-router, which provide instructions for an automated agent. The changes are clear and well-structured. My main feedback concerns some inconsistencies in network naming conventions across the new files and with existing documentation, and a minor markdown formatting issue. Additionally, for better organization, you might consider placing the celestia-docs-maintainer skill file within the skills/ directory, similar to the router skill.
| - Use network names/capitalization exactly, including: | ||
| - `Arabica devnet` | ||
| - `Coffee Beta` |
There was a problem hiding this comment.
There are some inconsistencies in the network names used here compared to other parts of the documentation and even within this file. For example:
- Line 20 mentions
Mocha, but it's missing from this example list. - Other documentation files (e.g.,
app/operate/networks/overview/page.mdx) refer to networks asMocha testnetandArabica devnet.
To ensure clarity and consistency, it would be beneficial to use the canonical network names and make this list of examples more complete. For instance, you might want to add an example for Mocha testnet and clarify if Arabica from line 20 should be Arabica devnet as used here.
| ## Minimal intake checklist | ||
|
|
||
| - What outcome is needed: behavior change, documentation change, or proposal/spec change? | ||
| - Which network scope is involved: Coffee Beta, Mocha, Arabica, or mainnet? |
There was a problem hiding this comment.
The list of network scopes here (Coffee Beta, Mocha, Arabica, or mainnet) appears to be inconsistent with the names used elsewhere in the documentation (e.g., Mainnet Beta, Mocha testnet, Arabica devnet). To improve clarity and prevent confusion when routing tasks, consider aligning these names with the canonical network names used across the project.
Overview