Update: Side nav home link to match top nav#804
Conversation
update to match home nav link in top nav
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Anatomy images need to be updated to match the content. Can be added to this PR. |
) Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) from 0.1.12 to 0.1.13. - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/v.0.1.13/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.12...v.0.1.13) --- updated-dependencies: - dependency-name: path-to-regexp dependency-version: 0.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps and [brace-expansion](https://github.com/juliangruber/brace-expansion). These dependencies needed to be updated together. Updates `brace-expansion` from 2.0.2 to 2.0.3 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v2.0.2...v2.0.3) Updates `brace-expansion` from 1.1.12 to 1.1.13 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 2.0.3 dependency-type: indirect - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js) from 4.7.8 to 4.7.9. - [Release notes](https://github.com/handlebars-lang/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.9/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.8...v4.7.9) --- updated-dependencies: - dependency-name: handlebars dependency-version: 4.7.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2. - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) --- updated-dependencies: - dependency-name: picomatch dependency-version: 2.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2. - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) --- updated-dependencies: - dependency-name: picomatch dependency-version: 2.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml' * chore: synced local '.github/workflows/backstage-catalog-helper.yml' with remote 'tools/sre_file_sync/backstage-catalog-helper.yml' * chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml' --------- Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
ethanWallace
left a comment
There was a problem hiding this comment.
Just a couple small things
| - For logos, include descriptive text. | ||
|
|
||
| Note: On mobile, the label does not link to the homepage. | ||
| Note: On mobile, the home nav link does not link to the homepage. |
There was a problem hiding this comment.
With the new home slot if a nav link is passed, this statement isn't true anymore.
There was a problem hiding this comment.
The new anatomy image shows and labels the home nav link as just text. We should show it as a link
There was a problem hiding this comment.
The styling of the home nav link (which looks like text) is consistent with the styling in the top navigation. Is that what is being referred to? @ethanWallace cc: @Charcharbinkz
There was a problem hiding this comment.
When a nav-link is in the home slot, the nav-link appears like the home link in the top nav. Our docs site has it currently set that way: https://design-system.canada.ca/en/
remove note on linking not working on mobile
remove note on linking not working on mobile
update to match home nav link in top nav
📝 Summary | Résumé
Side nav label is redesigned to function like the top nav home link. Updating the guidance to match this change and verbiage.
🧩 Related Issues | Cartes liées
🧪 Test instructions | Instructions pour tester la modification
Side nav anatomy image/list and top nav anatomy image/list both say "Home nav link".
No more references to "label" in the side nav guidance.
Preview links
English
French
✍️ Author checklist | Liste de vérification de l'auteur
Choose one (primary change type):
Breaking / impact flag:
Ready for review (all items must be checked):
🧐 Reviewer checklist | Liste de vérification du réviseur
Developer checklist (if applicable)
For complex PRs, in lieu of a simple approval or "LGTM" ✅, include the following with your approval:
Design checklist (if applicable)
For designers, include the following with your approval:
Content checklist (if applicable)
For content, include the following with your approval:
Optional: Highlight any potential implications, risks, or important notes for reviewers or maintainers (e.g., breaking changes, domain changes, removed pages, dependency updates, performance implications, etc.).
Highlight any deprecations or migration guidance here.