Skip to content

Update: Side nav home link to match top nav#804

Open
Charcharbinkz wants to merge 12 commits intomainfrom
update/sidenav-homelink-guidance
Open

Update: Side nav home link to match top nav#804
Charcharbinkz wants to merge 12 commits intomainfrom
update/sidenav-homelink-guidance

Conversation

@Charcharbinkz
Copy link
Copy Markdown
Contributor

@Charcharbinkz Charcharbinkz commented Mar 24, 2026

update to match home nav link in top nav

📝 Summary | Résumé

Side nav label is redesigned to function like the top nav home link. Updating the guidance to match this change and verbiage.

🧩 Related Issues | Cartes liées

🧪 Test instructions | Instructions pour tester la modification

Side nav anatomy image/list and top nav anatomy image/list both say "Home nav link".
No more references to "label" in the side nav guidance.

Preview links

English

French

✍️ Author checklist | Liste de vérification de l'auteur

Choose one (primary change type):

  • This PR introduces content changes (text, images, documentation updates).
  • This PR introduces structural changes (add/remove pages, navigation updates).
  • This PR introduces design changes (CSS, layout, visual adjustments).
  • This PR introduces development changes (scripts, utilities, features, API, domain, infrastructure).

Breaking / impact flag:

  • This PR does not break existing links (URLs, anchors, navigation).
  • If it does, redirects or migration guidance are documented under Impact/Risks.

Ready for review (all items must be checked):

  • I have verified the English and French versions are accurate, consistent, and properly displayed.
  • I have verified content follows GC Design System product content standards (if applicable).
  • I have verified changes on mobile viewports.
  • I have verified changes across supported browsers.
  • I have checked accessibility and ensured accessibility requirements continue to meet standards. :accessibility:
  • I have verified links, routes, and navigation behave correctly.
  • I have added or updated documentation as needed.
  • For visual or design changes, I have posted in the dev-design Slack channel.
  • I have ensured test instructions are clear and reproducible.

🧐 Reviewer checklist | Liste de vérification du réviseur

Developer checklist (if applicable)

For complex PRs, in lieu of a simple approval or "LGTM" ✅, include the following with your approval:

  • I have verified the changes using the provided test instructions.
  • I have verified the site builds successfully and runs without errors.
  • I have reviewed the implementation for clarity, maintainability, and potential issues.

Design checklist (if applicable)

For designers, include the following with your approval:

  • I have verified layout, spacing, visual hierarchy, and behaviour.
  • The changes align with design expectations, component guidance, and the design system.
  • I have verified accessibility considerations (contrast, focus states, semantics, motion, etc.).
  • I have verified behaviour matches documentation and expected interactions.
  • Changes have been reviewed across breakpoints and device sizes.
  • Any design inconsistencies have been raised in Slack or tracked via an issue.

Content checklist (if applicable)

For content, include the following with your approval:

  • I understand the context and intent of the content changes.
  • I have reviewed all content for clarity, readability, tone, and plain language alignment.
  • I have reviewed English and French content for accuracy, terminology consistency, and parity.
  • Terminology and naming follow GC and design system standards.
  • I have verified links, references, and examples are correct and functional.
  • I have verified descriptive (alt) text for accuracy and brevity.
  • The content follows and does not contradict design system guidance elsewhere on the site.
  • No spelling, grammar, or formatting issues are present.

⚠️ Impact/Risks | Risques

Optional: Highlight any potential implications, risks, or important notes for reviewers or maintainers (e.g., breaking changes, domain changes, removed pages, dependency updates, performance implications, etc.).
Highlight any deprecations or migration guidance here.

update to match home nav link in top nav
@aws-amplify-ca-central-1
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-804.djtlis5vpn8jd.amplifyapp.com

@aws-amplify-ca-central-1
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-804.d35vdwuoev573o.amplifyapp.com

@Charcharbinkz
Copy link
Copy Markdown
Contributor Author

Anatomy images need to be updated to match the content. Can be added to this PR.

dependabot bot and others added 8 commits April 1, 2026 13:31
)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) from 0.1.12 to 0.1.13.
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/v.0.1.13/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.12...v.0.1.13)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-version: 0.1.13
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps  and [brace-expansion](https://github.com/juliangruber/brace-expansion). These dependencies needed to be updated together.

Updates `brace-expansion` from 2.0.2 to 2.0.3
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v2.0.2...v2.0.3)

Updates `brace-expansion` from 1.1.12 to 1.1.13
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v2.0.2...v2.0.3)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 2.0.3
  dependency-type: indirect
- dependency-name: brace-expansion
  dependency-version: 1.1.13
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js) from 4.7.8 to 4.7.9.
- [Release notes](https://github.com/handlebars-lang/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.9/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.7.8...v4.7.9)

---
updated-dependencies:
- dependency-name: handlebars
  dependency-version: 4.7.9
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: synced local '.github/workflows/s3-backup.yml' with remote 'tools/sre_file_sync/s3-backup.yml'

* chore: synced local '.github/workflows/backstage-catalog-helper.yml' with remote 'tools/sre_file_sync/backstage-catalog-helper.yml'

* chore: synced local '.github/workflows/ossf-scorecard.yml' with remote 'tools/sre_file_sync/ossf-scorecard.yml'

---------

Co-authored-by: sre-read-write[bot] <92993749+sre-read-write[bot]@users.noreply.github.com>
melaniebmn
melaniebmn previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melaniebmn melaniebmn requested a review from ethanWallace April 1, 2026 20:43
Copy link
Copy Markdown
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things

- For logos, include descriptive text.

Note: On mobile, the label does not link to the homepage.
Note: On mobile, the home nav link does not link to the homepage.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new home slot if a nav link is passed, this statement isn't true anymore.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new anatomy image shows and labels the home nav link as just text. We should show it as a link

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styling of the home nav link (which looks like text) is consistent with the styling in the top navigation. Is that what is being referred to? @ethanWallace cc: @Charcharbinkz

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a nav-link is in the home slot, the nav-link appears like the home link in the top nav. Our docs site has it currently set that way: https://design-system.canada.ca/en/

remove note on linking not working on mobile
remove note on linking not working on mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants