Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
|
||
| ### Day, month, year format | ||
| - For a specific date the person will know or can easily find. | ||
| ### Month, day, year |
There was a problem hiding this comment.
Could it be confusing to have this information laid out like this since the month, day, year format is only available in English and the day, month, year is only available in French?
There was a problem hiding this comment.
Yeah this is a bit tricky. Thanks for flagging it.
In Figma, all options are available for selection regardless of what language is being used. (The language toggles after the format is selected) I tried to flag that one is for French written formats, one is for English. But you're right, it's still confusing.
I'll try to make this a little more obvious that m/d/y = English only and d/m/y = French only.
nchoquet
left a comment
There was a problem hiding this comment.
French content updated to match EN
|
LGTM! |
|
@daine ready to be reviewed and merged whenever makes sense for the code implementation. |
📝 Summary | Résumé
Update date input guidance to address the addition of a new format option: iso
🧩 Related Issues | Cartes liées
🧪 Test instructions | Instructions pour tester la modification
Minor content updates
Preview links
English
French
✍️ Author checklist | Liste de vérification de l'auteur
Choose one (primary change type):
Breaking / impact flag:
Ready for review (all items must be checked):
🧐 Reviewer checklist | Liste de vérification du réviseur
Developer checklist (if applicable)
For complex PRs, in lieu of a simple approval or "LGTM" ✅, include the following with your approval:
Design checklist (if applicable)
For designers, include the following with your approval:
Content checklist (if applicable)
For content, include the following with your approval:
Optional: Highlight any potential implications, risks, or important notes for reviewers or maintainers (e.g., breaking changes, domain changes, removed pages, dependency updates, performance implications, etc.).
Highlight any deprecations or migration guidance here.