Skip to content

Update/date-input-guidance.md#796

Open
Charcharbinkz wants to merge 15 commits intomainfrom
update/date-input-guidance
Open

Update/date-input-guidance.md#796
Charcharbinkz wants to merge 15 commits intomainfrom
update/date-input-guidance

Conversation

@Charcharbinkz
Copy link
Copy Markdown
Contributor

@Charcharbinkz Charcharbinkz commented Mar 5, 2026

📝 Summary | Résumé

Update date input guidance to address the addition of a new format option: iso

🧩 Related Issues | Cartes liées

  • Zenhub issue: #2309

🧪 Test instructions | Instructions pour tester la modification

Minor content updates

Preview links

English

French

✍️ Author checklist | Liste de vérification de l'auteur

Choose one (primary change type):

  • This PR introduces content changes (text, images, documentation updates).
  • This PR introduces structural changes (add/remove pages, navigation updates).
  • This PR introduces design changes (CSS, layout, visual adjustments).
  • This PR introduces development changes (scripts, utilities, features, API, domain, infrastructure).

Breaking / impact flag:

  • This PR does not break existing links (URLs, anchors, navigation).
  • If it does, redirects or migration guidance are documented under Impact/Risks.

Ready for review (all items must be checked):

  • I have verified the English and French versions are accurate, consistent, and properly displayed.
  • I have verified content follows GC Design System product content standards (if applicable).
  • I have verified changes on mobile viewports.
  • I have verified changes across supported browsers.
  • I have checked accessibility and ensured accessibility requirements continue to meet standards. :accessibility:
  • I have verified links, routes, and navigation behave correctly.
  • I have added or updated documentation as needed.
  • For visual or design changes, I have posted in the dev-design Slack channel.
  • I have ensured test instructions are clear and reproducible.

🧐 Reviewer checklist | Liste de vérification du réviseur

Developer checklist (if applicable)

For complex PRs, in lieu of a simple approval or "LGTM" ✅, include the following with your approval:

  • I have verified the changes using the provided test instructions.
  • I have verified the site builds successfully and runs without errors.
  • I have reviewed the implementation for clarity, maintainability, and potential issues.

Design checklist (if applicable)

For designers, include the following with your approval:

  • I have verified layout, spacing, visual hierarchy, and behaviour.
  • The changes align with design expectations, component guidance, and the design system.
  • I have verified accessibility considerations (contrast, focus states, semantics, motion, etc.).
  • I have verified behaviour matches documentation and expected interactions.
  • Changes have been reviewed across breakpoints and device sizes.
  • Any design inconsistencies have been raised in Slack or tracked via an issue.

Content checklist (if applicable)

For content, include the following with your approval:

  • I understand the context and intent of the content changes.
  • I have reviewed all content for clarity, readability, tone, and plain language alignment.
  • I have reviewed English and French content for accuracy, terminology consistency, and parity.
  • Terminology and naming follow GC and design system standards.
  • I have verified links, references, and examples are correct and functional.
  • I have verified descriptive (alt) text for accuracy and brevity.
  • The content follows and does not contradict design system guidance elsewhere on the site.
  • No spelling, grammar, or formatting issues are present.

⚠️ Impact/Risks | Risques

Optional: Highlight any potential implications, risks, or important notes for reviewers or maintainers (e.g., breaking changes, domain changes, removed pages, dependency updates, performance implications, etc.).
Highlight any deprecations or migration guidance here.

@aws-amplify-ca-central-1
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-796.djtlis5vpn8jd.amplifyapp.com

@aws-amplify-ca-central-1
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-796.d35vdwuoev573o.amplifyapp.com


### Day, month, year format
- For a specific date the person will know or can easily find.
### Month, day, year
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be confusing to have this information laid out like this since the month, day, year format is only available in English and the day, month, year is only available in French?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a bit tricky. Thanks for flagging it.

In Figma, all options are available for selection regardless of what language is being used. (The language toggles after the format is selected) I tried to flag that one is for French written formats, one is for English. But you're right, it's still confusing.

I'll try to make this a little more obvious that m/d/y = English only and d/m/y = French only.

nmakuch
nmakuch previously approved these changes Mar 18, 2026
Copy link
Copy Markdown
Contributor

@nmakuch nmakuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Charcharbinkz Charcharbinkz requested a review from nchoquet March 18, 2026 15:51
Copy link
Copy Markdown
Contributor

@nchoquet nchoquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French content updated to match EN

@Charcharbinkz Charcharbinkz marked this pull request as ready for review April 1, 2026 18:23
@Charcharbinkz Charcharbinkz requested a review from a team as a code owner April 1, 2026 18:23
@Charcharbinkz Charcharbinkz requested a review from nmakuch April 1, 2026 18:30
@Charcharbinkz
Copy link
Copy Markdown
Contributor Author

LGTM!

@Charcharbinkz
Copy link
Copy Markdown
Contributor Author

@daine ready to be reviewed and merged whenever makes sense for the code implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants