Fix skill tools double-classified as both delegate and integrate#96
Closed
cursor[bot] wants to merge 1 commit intofeat/session-workflow-fingerprintsfrom
Closed
Conversation
Remove 'skill' from _INTEGRATE_HINTS to prevent Skill:-prefixed tools from matching _is_integrate_tool via substring matching. These tools are already correctly classified as delegates via classify_tool returning 'skill' in _is_delegate_tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_INTEGRATE_HINTSincluded"skill", which caused anySkill:-prefixed tool (e.g.,Skill:myskill) to match_is_integrate_toolvia substring matching ("skill" in "skill:myskill"). These same tools already correctly match_is_delegate_toolbecauseclassify_toolreturns"skill"for them.This double-classification added spurious
"integrate"steps to workflow fingerprints for sessions using Skill tools, producing differentfingerprint_idvalues than intended (e.g.,"...+delegate+integrate+..."instead of"...+delegate+...").Fix
Remove
"skill"from_INTEGRATE_HINTS. Skill tools are delegates, not integrations — the originalinfer_workflow_stepscode only added the "integrate" step forclassify_tool(name) == "mcp", never for skill-classified tools.