Centralize formatMetric utility in utils.ts#116
Merged
ccf merged 1 commit intofeat/workflow-compare-modefrom Mar 16, 2026
Merged
Centralize formatMetric utility in utils.ts#116ccf merged 1 commit intofeat/workflow-compare-modefrom
formatMetric utility in utils.ts#116ccf merged 1 commit intofeat/workflow-compare-modefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the duplicated
formatMetrichelper intofrontend/src/lib/utils.ts, removing independent copies from three component files.Changes
frontend/src/lib/utils.ts: Added centralizedformatMetric(value, digits)function alongside existing formatting utilities (formatCost,formatPercent, etc.)frontend/src/components/finops/workflow-compare-card.tsx: Removed localformatMetric, importing fromutils.tsfrontend/src/components/quality/quality-attribution-table.tsx: Removed localformatMetric, importing fromutils.tsfrontend/src/components/quality/claude-pr-comparison.tsx: Replaced localformatMetricwith import fromutils.ts; renamed the suffix-appending wrapper toformatMetricWithSuffixwhich delegates to the centralized versionMotivation
Three independent copies of null-safe numeric formatting logic (
value == null ? "-" : value.toFixed(digits)) existed across the codebase. A bug fix in one copy could easily be missed in the others. This centralizes the logic inutils.tswhere all other formatting functions live.